Use weak cells in map checks in polymorphic ICs.

Use weak cells in map checks in polymorphic ICs.

BUG=v8:3663
LOG=N

[ulan, 2014-11-26 14:15:25]

ulan@chromium.org changed reviewers:
+ mvstanton@chromium.org

[ulan, 2014-11-26 14:15:26]

Michael, could you please take a look. If it looks ok, I'll implement other
platforms.

Hannes, Toon, Jakob: this is fyi.

[mvstanton, 2014-11-26 14:18:21]

Yep, make ports and let's see.

https://codereview.chromium.org/753993003/diff/1/src/heap/objects-visiting-inl.h
File src/heap/objects-visiting-inl.h (left):

https://codereview.chromium.org/753993003/diff/1/src/heap/objects-visiting-in...
src/heap/objects-visiting-inl.h:267: target->ic_state() == POLYMORPHIC ||
w00t!

[ulan, 2014-11-27 13:16:39]

> Yep, make ports and let's see.
Done. I also fixed Code::FindFirstHandler and Code::FindHandlers to skip
invalidated branches.

[mvstanton, 2014-11-27 17:00:11]

Hi Ulan, just get a test over in test-heap.cc along the lines of
IncrementalMarkingPreservedMonomorphicIC, make sure that the notion of
polymorphic ICs staying preserved is covered there too. All the code thus far
looks good.

[ulan, 2014-11-28 14:14:20]

On 2014/11/27 17:00:11, mvstanton wrote:
> Hi Ulan, just get a test over in test-heap.cc along the lines of
> IncrementalMarkingPreservedMonomorphicIC, make sure that the notion of
> polymorphic ICs staying preserved is covered there too. All the code thus far
> looks good.

Added IncrementalMarkingPreservedPolymorhpicIC and few tests that check weakness
of maps in polymorphic ICs.

[ulan, 2014-11-28 14:15:09]

ulan@chromium.org changed reviewers:
+ akos.palfi@imgtec.com, weiliang.lin@intel.com

[ulan, 2014-11-28 14:27:36]

Akos, Weiliang, could you please take a look at mips and x87 ports?

[Weiliang, 2014-12-01 04:34:36]

On 2014/11/28 14:27:36, ulan wrote:
> Akos, Weiliang, could you please take a look at mips and x87 ports?

Hi ulan, 
The x87 port looks good to me. Thanks a lot for the change of x87 port. 

Thanks
-Weiliang

[mvstanton, 2014-12-01 07:57:10]

Right on, LGTM.

[ulan, 2014-12-01 10:10:50]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2014-12-01 10:11:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753993003/140001

[akos.palfi.imgtec, 2014-12-01 10:27:59]

LGTM, Thank you for the ports!

[commit-bot: I haz the power, 2014-12-01 10:41:11]

Committed patchset #8 (id:140001)

[Michael Achenbach, 2014-12-02 08:13:19]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/771033003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for breaking chromium
asan (roll blocker):
http://build.chromium.org/p/client.v8/builders/Linux%20ASan%20LSan%20Tests%20....