Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html

Issue 77043010: - Ensure that classes are finalized before their description is (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html
===================================================================
--- runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html (revision 30528)
+++ runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html (working copy)
@@ -1,5 +1,6 @@
<head>
<link rel="import" href="observatory_element.html">
+ <link rel="import" href="error_view.html">
</head>
<polymer-element name="class-view" extends="observatory-element">
<template>
@@ -38,36 +39,41 @@
</tr>
</tbody>
</table>
- <blockquote><strong>Fields</strong></blockquote>
- <table class="table table-hover">
- <thead>
- <tr>
- <th>User Name</th>
- <th>VM Name</th>
- </tr>
- </thead>
- <tbody>
- <tr template repeat="{{ field in cls['fields'] }}">
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['user_name'] }}</a></td>
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['name'] }}</a></td>
- </tr>
- </tbody>
- </table>
- <blockquote><strong>Functions</strong></blockquote>
- <table class="table table-hover">
- <thead>
- <tr>
- <th>User Name</th>
- <th>VM Name</th>
- </tr>
- </thead>
- <tbody>
- <tr template repeat="{{ function in cls['functions'] }}">
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['user_name'] }}</a></td>
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['name'] }}</a></td>
- </tr>
- </tbody>
- </table>
+ <template if="{{ cls['error'] == null }}">
+ <blockquote><strong>Fields</strong></blockquote>
+ <table class="table table-hover">
+ <thead>
+ <tr>
+ <th>User Name</th>
+ <th>VM Name</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr template repeat="{{ field in cls['fields'] }}">
+ <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['user_name'] }}</a></td>
+ <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['name'] }}</a></td>
+ </tr>
+ </tbody>
+ </table>
+ <blockquote><strong>Functions</strong></blockquote>
+ <table class="table table-hover">
+ <thead>
+ <tr>
+ <th>User Name</th>
+ <th>VM Name</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr template repeat="{{ function in cls['functions'] }}">
+ <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['user_name'] }}</a></td>
+ <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['name'] }}</a></td>
+ </tr>
+ </tbody>
+ </table>
+ </template>
+ <template if="{{ cls['error'] != null }}">
+ <error-view error_obj="{{ cls['error'] }}"></error-view>
+ </template>
</div>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698