Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 770053002: gn format: Special case for single arg function calls containing boolean ops (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-unnecessary-parens
Project:
chromium
Visibility:
Public.

Description

gn format: Special case for single arg function calls containing boolean ops Follows https://codereview.chromium.org/772663002/ . R=brettw@chromium.org BUG=348474 Committed: https://crrev.com/78c18bdb7076e2d91e6776e030a1d5b8d44dd247 Cr-Commit-Position: refs/heads/master@{#306297}

Patch Set 1 #

Patch Set 2 : if too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M tools/gn/command_format.cc View 4 chunks +18 lines, -5 lines 0 comments Download
M tools/gn/command_format_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A tools/gn/format_test_data/059.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/059.golden View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
scottmg
6 years ago (2014-12-01 22:28:02 UTC) #1
brettw
I don't see any test cases for a multiline if (which looks like a single-arg ...
6 years ago (2014-12-01 22:31:18 UTC) #2
scottmg
On 2014/12/01 22:31:18, brettw wrote: > I don't see any test cases for a multiline ...
6 years ago (2014-12-01 22:43:40 UTC) #3
brettw
lgtm
6 years ago (2014-12-01 22:45:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770053002/20001
6 years ago (2014-12-01 22:53:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-01 23:54:14 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-01 23:55:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78c18bdb7076e2d91e6776e030a1d5b8d44dd247
Cr-Commit-Position: refs/heads/master@{#306297}

Powered by Google App Engine
This is Rietveld 408576698