gn format: Special case for single arg function calls containing boolean ops

tools/gn/command_format.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/strings/string_split.h"
 #include "tools/gn/commands.h"
@@ skipping 668 matching lines @@
 
   // Calculate the penalties for 3 possible layouts:
   // 1. all on same line;
   // 2. starting on same line, broken at each comma but paren aligned;
   // 3. broken to next line + 4, broken at each comma.
   std::string terminator = ")";
   if (have_block)
     terminator += " {";
   terminator += suffix;
 
+  // Special case to make function calls of one arg taking a long list of
+  // boolean operators not indent.
+  bool continuation_requires_indent =
+      list.size() != 1 || !list[0]->AsBinaryOp() ||
+      (list[0]->AsBinaryOp()->op().value() != "||" &&
+       list[0]->AsBinaryOp()->op().value() != "&&");
+
   // 1: Same line.
   Printer sub1;
   InitializeSub(&sub1);
-  sub1.stack_.push_back(IndentState(CurrentColumn(), true, false));
+  sub1.stack_.push_back(
+      IndentState(CurrentColumn(), continuation_requires_indent, false));
   int penalty_one_line = 0;
   for (size_t i = 0; i < list.size(); ++i) {
     penalty_one_line += sub1.Expr(list[i], kPrecedenceLowest,
                                   i < list.size() - 1 ? ", " : std::string());
   }
   sub1.Print(terminator);
   penalty_one_line += AssessPenalty(sub1.String());
   // This extra penalty prevents a short second argument from being squeezed in
   // after a first argument that went multiline (and instead preferring a
   // variant below).
   penalty_one_line +=
       (CountLines(sub1.String()) - 1) * kPenaltyBrokenLineOnOneLiner;
 
   // 2: Starting on same line, broken at commas.
   Printer sub2;
   InitializeSub(&sub2);
-  sub2.stack_.push_back(IndentState(CurrentColumn(), true, false));
+  sub2.stack_.push_back(
+      IndentState(CurrentColumn(), continuation_requires_indent, false));
   int penalty_multiline_start_same_line = 0;
   for (size_t i = 0; i < list.size(); ++i) {
     penalty_multiline_start_same_line += sub2.Expr(
         list[i], kPrecedenceLowest, i < list.size() - 1 ? "," : std::string());
     if (i < list.size() - 1) {
       sub2.Newline();
     }
   }
   sub2.Print(terminator);
   penalty_multiline_start_same_line += AssessPenalty(sub2.String());
 
   // 3: Starting on next line, broken at commas.
   Printer sub3;
   InitializeSub(&sub3);
-  sub3.stack_.push_back(IndentState(margin() + kIndentSize * 2, true, false));
+  sub3.stack_.push_back(IndentState(margin() + kIndentSize * 2,
+                                    continuation_requires_indent, false));
   sub3.Newline();
   int penalty_multiline_start_next_line = 0;
   for (size_t i = 0; i < list.size(); ++i) {
     if (i == 0) {
       penalty_multiline_start_next_line +=
           std::abs(sub3.CurrentColumn() - start_column) *
           kPenaltyHorizontalSeparation;
     }
     penalty_multiline_start_next_line += sub3.Expr(
         list[i], kPrecedenceLowest, i < list.size() - 1 ? "," : std::string());
@@ skipping 15 matching lines @@
       force_multiline = true;
     }
   } else {
     force_multiline = true;
   }
 
   if (list.size() == 0 && !force_multiline) {
     // No elements, and not forcing newlines, print nothing.
   } else {
     if (penalty_multiline_start_next_line < penalty_multiline_start_same_line) {
-      stack_.push_back(IndentState(margin() + kIndentSize * 2, true, false));
+      stack_.push_back(IndentState(margin() + kIndentSize * 2,
+                                   continuation_requires_indent,
+                                   false));
       Newline();
     } else {
-      stack_.push_back(IndentState(CurrentColumn(), true, false));
+      stack_.push_back(
+          IndentState(CurrentColumn(), continuation_requires_indent, false));
     }
 
     for (size_t i = 0; i < list.size(); ++i) {
       const auto& x = list[i];
       if (i > 0) {
         if (fits_on_current_line && !force_multiline)
           Print(" ");
         else
           Newline();
       }
@@ skipping 190 matching lines @@
       printf("Wrote formatted to '%s'.\n", to_write.AsUTF8Unsafe().c_str());
     } else {
       printf("%s", output_string.c_str());
     }
   }
 
   return 0;
 }
 
 }  // namespace commands