[turbofan] Add TraversalState and GraphTraversal and use them in GraphReducer.

[turbofan] Add NodeMarker and use it in the GraphReducer.

R=mstarzinger@chromium.org
BUG=

Committed: https://chromium.googlesource.com/v8/v8/+/6f60c0d3b83efe05cff992c460f4f8df325e0204

[Michael Starzinger, 2014-11-28 11:27:27]

https://codereview.chromium.org/768763002/diff/1/src/compiler/graph.h
File src/compiler/graph.h (right):

https://codereview.chromium.org/768763002/diff/1/src/compiler/graph.h#newcode22
src/compiler/graph.h:22: template <typename LocalState>
nit: Can we use s/LocalState/State/ here for readability?

https://codereview.chromium.org/768763002/diff/1/src/compiler/graph.h#newcode23
src/compiler/graph.h:23: class GraphTraversal : public ZoneObject {
As discussed offline: Since this is not really a "traversal" but just the "state
for a traversal", how about calling it NodeState? This would also warrant moving
it into the node.h file.

https://codereview.chromium.org/768763002/diff/1/src/compiler/graph.h#newcode115
src/compiler/graph.h:115: template <typename LocalState>
nit: Can we use s/LocalState/State/ here for readability?

[titzer, 2014-11-28 12:01:05]

On 2014/11/28 11:27:27, Michael Starzinger wrote:
> https://codereview.chromium.org/768763002/diff/1/src/compiler/graph.h
> File src/compiler/graph.h (right):
> 
>
https://codereview.chromium.org/768763002/diff/1/src/compiler/graph.h#newcode22
> src/compiler/graph.h:22: template <typename LocalState>
> nit: Can we use s/LocalState/State/ here for readability?
> 
>
https://codereview.chromium.org/768763002/diff/1/src/compiler/graph.h#newcode23
> src/compiler/graph.h:23: class GraphTraversal : public ZoneObject {
> As discussed offline: Since this is not really a "traversal" but just the
"state
> for a traversal", how about calling it NodeState? This would also warrant
moving
> it into the node.h file.
> 
>
https://codereview.chromium.org/768763002/diff/1/src/compiler/graph.h#newcode115
> src/compiler/graph.h:115: template <typename LocalState>
> nit: Can we use s/LocalState/State/ here for readability?

PTAL, I've renamed GraphTraversal to NodeMarker.

[Michael Starzinger, 2014-11-28 12:09:44]

LGTM.

[Michael Starzinger, 2014-11-28 12:12:36]

https://codereview.chromium.org/768763002/diff/60001/src/compiler/graph.h
File src/compiler/graph.h (right):

https://codereview.chromium.org/768763002/diff/60001/src/compiler/graph.h#new...
src/compiler/graph.h:91: class NodeMarker : public ZoneObject {
nit: Does it still need to be a ZoneObject?

[titzer, 2014-11-28 12:15:52]

On 2014/11/28 12:12:36, Michael Starzinger wrote:
> https://codereview.chromium.org/768763002/diff/60001/src/compiler/graph.h
> File src/compiler/graph.h (right):
> 
>
https://codereview.chromium.org/768763002/diff/60001/src/compiler/graph.h#new...
> src/compiler/graph.h:91: class NodeMarker : public ZoneObject {
> nit: Does it still need to be a ZoneObject?

Done.

[titzer, 2014-11-28 12:21:20]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2014-11-28 12:21:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/768763002/80001

[titzer, 2014-11-28 12:21:45]

The CQ bit was unchecked by titzer@chromium.org

[titzer, 2014-11-28 12:22:06]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2014-11-28 12:22:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/768763002/80001

[titzer, 2014-11-28 13:04:38]

The CQ bit was unchecked by titzer@chromium.org

[titzer, 2014-11-28 13:05:06]

Committed patchset #5 (id:80001) manually as
6f60c0d3b83efe05cff992c460f4f8df325e0204 (presubmit successful).