cc: Rename TileManager::ManageTiles to PrepareTiles.

cc: Rename TileManager::ManageTiles to PrepareTiles.

Renaming ManageTiles to PrepareTiles in preparation for re-factoring TileManager APIs for CPU & GPU (Ganesh).

BUG=440238
Committed: https://crrev.com/59ea9b4048daae81ba3e58ce5855d699c8dae4a2
Cr-Commit-Position: refs/heads/master@{#307545}

[vmiura, 2014-12-09 03:01:24]

vmiura@chromium.org changed reviewers:
+ brianderson@chromium.org, reveman@chromium.org, vmpstr@chromium.org

[vmiura, 2014-12-09 03:01:25]

vmpstr@chromium.org, reveman@chromium.org: Please review changes in resources/
and trees/.

brianderson@chromium.org: Please review changes in CC scheduler.

[brianderson, 2014-12-09 03:30:07]

Scheduler lgtm, but a couple comments need to be fixed.

https://codereview.chromium.org/767083005/diff/1/cc/scheduler/scheduler_state...
File cc/scheduler/scheduler_state_machine.h (right):

https://codereview.chromium.org/767083005/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine.h:168: // Indicates that manage-tiles is
required. This guarantees another
Fix comment

https://codereview.chromium.org/767083005/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine.h:313: // ManageTile per BeginImplFrame.
ManageTile per BeginImplFrame -> PrepareTile per...

[reveman, 2014-12-09 05:04:11]

lgtm % vmpstr's review

https://codereview.chromium.org/767083005/diff/1/cc/resources/tile_manager.h
File cc/resources/tile_manager.h (right):

https://codereview.chromium.org/767083005/diff/1/cc/resources/tile_manager.h#...
cc/resources/tile_manager.h:109: void PrepareTiles(const
GlobalStateThatImpactsTilePriority& state);
This should have been done in the past but as you're changing this, can you add
a comment here that explain a bit about what this function does? Maybe something
along the lines of "Assigns memory to tiles and schedules work to prepare tiles
for drawing".

[vmpstr, 2014-12-09 17:30:23]

lgtm

[vmiura, 2014-12-09 18:08:46]

https://codereview.chromium.org/767083005/diff/1/cc/resources/tile_manager.h
File cc/resources/tile_manager.h (right):

https://codereview.chromium.org/767083005/diff/1/cc/resources/tile_manager.h#...
cc/resources/tile_manager.h:109: void PrepareTiles(const
GlobalStateThatImpactsTilePriority& state);
On 2014/12/09 05:04:11, reveman wrote:
> This should have been done in the past but as you're changing this, can you
add
> a comment here that explain a bit about what this function does? Maybe
something
> along the lines of "Assigns memory to tiles and schedules work to prepare
tiles
> for drawing".

Done.

https://codereview.chromium.org/767083005/diff/1/cc/scheduler/scheduler_state...
File cc/scheduler/scheduler_state_machine.h (right):

https://codereview.chromium.org/767083005/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine.h:168: // Indicates that manage-tiles is
required. This guarantees another
On 2014/12/09 03:30:07, brianderson wrote:
> Fix comment

Done.

https://codereview.chromium.org/767083005/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine.h:313: // ManageTile per BeginImplFrame.
On 2014/12/09 03:30:07, brianderson wrote:
> ManageTile per BeginImplFrame -> PrepareTile per...

Done.

[vmiura, 2014-12-09 19:26:49]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2014-12-09 19:27:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/767083005/40001

[commit-bot: I haz the power, 2014-12-09 20:50:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-09 20:51:35]

Patchset 3 (id:??) landed as
https://crrev.com/59ea9b4048daae81ba3e58ce5855d699c8dae4a2
Cr-Commit-Position: refs/heads/master@{#307545}