Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 767073002: Removing WebRTC Java API (Closed)

Created:
6 years ago by SeRya
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing WebRTC Java API It's not used any longer. Was added in https://codereview.chromium.org/551793003/ as temporary solution to use WebRTC from android service. In following CLs we've moved to native API: https://codereview.chromium.org/704613003 https://codereview.chromium.org/716433003 https://codereview.chromium.org/719043002 https://codereview.chromium.org/734313002 There is no plan to use Java API for DevTools bridge again. BUG=383418

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -63 lines) Patch
M third_party/libjingle/BUILD.gn View 1 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
SeRya
PTAL
6 years ago (2014-11-30 17:09:32 UTC) #2
kjellander_chromium
+perkj as he's been working with this code lately. Per: Do we have this code ...
6 years ago (2014-12-01 10:39:10 UTC) #4
perkj_webrtc
On 2014/12/01 10:39:10, kjellander wrote: > +perkj as he's been working with this code lately. ...
6 years ago (2014-12-01 16:46:22 UTC) #5
hellner1
CL seems OK to me. Not completely clear to me how the bug referenced ties ...
6 years ago (2014-12-01 17:14:20 UTC) #6
SeRya
On 2014/12/01 17:14:20, hellner1 wrote: > CL seems OK to me. Not completely clear to ...
6 years ago (2014-12-03 13:26:55 UTC) #7
hellner1
On 2014/12/03 13:26:55, SeRya wrote: > On 2014/12/01 17:14:20, hellner1 wrote: > > CL seems ...
6 years ago (2014-12-03 16:54:12 UTC) #8
SeRya
On 2014/12/03 16:54:12, hellner1 wrote: > On 2014/12/03 13:26:55, SeRya wrote: > > On 2014/12/01 ...
6 years ago (2014-12-12 19:56:47 UTC) #9
perkj_chrome
On 2014/12/12 19:56:47, SeRya wrote: > On 2014/12/03 16:54:12, hellner1 wrote: > > On 2014/12/03 ...
6 years ago (2014-12-16 08:11:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767073002/1
6 years ago (2014-12-16 08:13:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30739) win_chromium_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/8894)
6 years ago (2014-12-16 08:19:59 UTC) #14
kjellander_chromium
Should you attempt a rebase+reland?
5 years, 11 months ago (2015-01-26 11:02:41 UTC) #15
kjellander_chromium
On 2015/01/26 11:02:41, kjellander wrote: > Should you attempt a rebase+reland? Ping!
5 years, 9 months ago (2015-03-03 08:48:22 UTC) #16
mnaganov (inactive)
5 years, 9 months ago (2015-03-04 16:05:32 UTC) #17
Message was sent while issue was closed.
On 2015/03/03 08:48:22, kjellander wrote:
> On 2015/01/26 11:02:41, kjellander wrote:
> > Should you attempt a rebase+reland?
> 
> Ping!

Rebased as https://codereview.chromium.org/982563002/

Powered by Google App Engine
This is Rietveld 408576698