chrome/test/ui/javascript_test_util.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/ui/javascript_test_util.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/ui/javascript_test_util.cc

diff --git a/chrome/test/ui/javascript_test_util.cc b/chrome/test/ui/javascript_test_util.cc

index 87dcbb7024781c4fc64d74c4a3096ba3b46088e7..dc9b143b2e37a3ce1418ad9dc763e4b8b5066c28 100644

--- a/chrome/test/ui/javascript_test_util.cc

+++ b/chrome/test/ui/javascript_test_util.cc

@@ -24,8 +24,8 @@ bool JsonDictionaryToMap(const std::string& json,

if (!root.get())

return false;

- EXPECT_TRUE(root->IsType(Value::TYPE_DICTIONARY));

- if (!root->IsType(Value::TYPE_DICTIONARY))

+ EXPECT_TRUE(root->IsDictionary());

+ if (!root->IsDictionary())

return false;

DictionaryValue* dict = static_cast<DictionaryValue*>(root.get());

« no previous file with comments | « chrome/test/perf/dom_checker_uitest.cc ('k') | chrome/test/webdriver/commands/command.cc » ('j') | no next file with comments »