Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/test/perf/dom_checker_uitest.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/ui_test_utils.cc ('k') | chrome/test/ui/javascript_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/dom_checker_uitest.cc
diff --git a/chrome/test/perf/dom_checker_uitest.cc b/chrome/test/perf/dom_checker_uitest.cc
index 6ca9c1a4681189215c4de2b0e4f820b69584326c..e60b4a21ac494dfc1d873bcaaf5cb72bb3b5f509 100644
--- a/chrome/test/perf/dom_checker_uitest.cc
+++ b/chrome/test/perf/dom_checker_uitest.cc
@@ -175,8 +175,8 @@ class DomCheckerTest : public UITest {
if (!value.get())
return false;
- EXPECT_TRUE(value->IsType(Value::TYPE_LIST));
- if (!value->IsType(Value::TYPE_LIST))
+ EXPECT_TRUE(value->IsList());
+ if (!value->IsList())
return false;
ListValue* list_value = static_cast<ListValue*>(value.get());
@@ -185,8 +185,8 @@ class DomCheckerTest : public UITest {
// test failure. Add those strings to the results set.
ListValue::const_iterator it = list_value->begin();
for (; it != list_value->end(); ++it) {
- EXPECT_TRUE((*it)->IsType(Value::TYPE_STRING));
- if ((*it)->IsType(Value::TYPE_STRING)) {
+ EXPECT_TRUE((*it)->IsString());
+ if ((*it)->IsString()) {
std::string test_name;
succeeded = (*it)->GetAsString(&test_name);
EXPECT_TRUE(succeeded);
« no previous file with comments | « chrome/test/base/ui_test_utils.cc ('k') | chrome/test/ui/javascript_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698