chrome/test/webdriver/commands/command.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/commands/command.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/commands/command.cc

diff --git a/chrome/test/webdriver/commands/command.cc b/chrome/test/webdriver/commands/command.cc

index 95ad878f54fed029c992e52aaa1dbb8505a671bb..7d6cb1643a09ca0f30ee7db1d181b5be1a6d98d5 100644

--- a/chrome/test/webdriver/commands/command.cc

+++ b/chrome/test/webdriver/commands/command.cc

@@ -39,9 +39,7 @@ bool Command::HasParameter(const std::string& key) const {

bool Command::IsNullParameter(const std::string& key) const {

Value* value;

- return parameters_.get() &&

- parameters_->Get(key, &value) &&

- value->IsType(Value::TYPE_NULL);

+ return parameters_.get() && parameters_->Get(key, &value) && value->IsNull();

}

bool Command::GetStringParameter(const std::string& key,