Descriptiontext-justify has been broken for Chinese and Japanese. This patch fixes this
to the same behavior of WebKit.
There are 3 code path to justify; LChar+SimpleShaper, UChar+SimplerShaper,
and UChar+HarfbuzzShaper. This patch fixes UChar and SimpleShaper code
path. Chinese and Japanese justification always occur at UChar (not LChar),
and SimpleShaper is used most of the time for these scripts. I'll work on
complex path later in another patch.
Tests imported from WebKit were rebaselined to incorrect results at some
point. I rebaselined all such tests by looking at them and by comparing the
results with WebKit. Also one ref test was added.
Note that Chinese/Japanese justification had been disabled under the switch
|canExpandAroundIdeographsInComplexText| for Blink except on Mac, and
then it was removed because it's off in
https://codereview.chromium.org/618383003.
What this patch means in that context is to fix SimpleShaper to support the
switch and turn it back always, as long as text-justify: auto, which is the same
as WebKit behavior.
BUG=248894, 368108
TEST=fast/text/justify-ideograph.html
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187112
Patch Set 1 : WIP #Patch Set 2 : TestExpectations updated #Patch Set 3 : More test cases added, no changes in code #Patch Set 4 : One more NeedsRebaseline for Linux and Win #
Messages
Total messages: 7 (3 generated)
|