Source/platform/fonts/shaping/SimpleShaper.cpp - Issue 766053004: text-justify fix for Chinese and Japanese

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/SimpleShaper.cpp

Issue 766053004: text-justify fix for Chinese and Japanese (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: One more NeedsRebaseline for Linux and Win Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/shaping/SimpleShaper.cpp

diff --git a/Source/platform/fonts/shaping/SimpleShaper.cpp b/Source/platform/fonts/shaping/SimpleShaper.cpp

index e60432830685c497726631141c47cf33a232c765..4c18b3a7c158248c407792eb91f0aefd1ff312c6 100644

--- a/Source/platform/fonts/shaping/SimpleShaper.cpp

+++ b/Source/platform/fonts/shaping/SimpleShaper.cpp

@@ -105,7 +105,7 @@ float SimpleShaper::adjustSpacing(float width, const CharacterData& charData)

width += m_font->fontDescription().letterSpacing();

bool isExpansionOpportunity = Character::treatAsSpace(charData.character) || (m_run.textJustify() == TextJustifyDistribute);

- if (isExpansionOpportunity) {

+ if (isExpansionOpportunity || (m_run.textJustify() == TextJustifyAuto && Character::isCJKIdeographOrSymbol(charData.character))) {

// Distribute the run's total expansion evenly over all expansion opportunities in the run.

if (m_expansion) {

if (!isExpansionOpportunity && !m_isAfterExpansion) {

« no previous file with comments | « Source/platform/fonts/Character.cpp ('k') | no next file » | no next file with comments »