Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 618383003: Remove obsolete canExpandAroundIdeographsInComplexText (Closed)

Created:
6 years, 2 months ago by eae
Modified:
6 years, 2 months ago
CC:
blink-reviews, Rik, danakj, krit, jamesr, jbroman, mkwst+moarreviews_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove obsolete canExpandAroundIdeographsInComplexText Remove the canExpandAroundIdeographsInComplexText flag as is no longer supported on any platform. As this was the only feature in the FontPlatformFeatures class this change also removes the class itself. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -75 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/Character.cpp View 4 chunks +0 lines, -16 lines 0 comments Download
M Source/platform/fonts/Font.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/platform/fonts/FontPlatformFeatures.h View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/platform/fonts/SimpleShaper.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
eae
6 years, 2 months ago (2014-10-01 23:03:58 UTC) #1
eae
(+1 line, -75 lines) :)
6 years, 2 months ago (2014-10-01 23:08:09 UTC) #2
leviw_travelin_and_unemployed
Holy crap yes! LGTM!
6 years, 2 months ago (2014-10-02 00:29:31 UTC) #3
eae
On 2014/10/02 00:29:31, leviw wrote: > Holy crap yes! LGTM! Thanks!
6 years, 2 months ago (2014-10-02 00:52:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618383003/1
6 years, 2 months ago (2014-10-02 00:53:58 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 02:09:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183109

Powered by Google App Engine
This is Rietveld 408576698