Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 765843003: Refactor GuestViewContainer::AttachRequest to allow for other request types (Closed)

Created:
6 years ago by Fady Samuel
Modified:
6 years ago
Reviewers:
paulmeyer
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor GuestViewContainer::AttachRequest to allow for other request types In a subsequent CL, DetachGuest will be introduced, to allow a GuestView to detach itself from its container. This CL performs the necessary refactor to allow for new operations to be easily introduced. This CL also makes BrowserPlugin IDs unique per process. This allows addressing attachment, and soon detachment, across JavaScript contexts. BUG=434226 TBR=lazyboy@chromium.org Committed: https://crrev.com/d397750f3e2e53f414a4798c4e5039837a8c00ea Cr-Commit-Position: refs/heads/master@{#306025} Committed: https://crrev.com/d0ff598d6d604ba3ac0cc940c27d5898c2640658 Cr-Commit-Position: refs/heads/master@{#306101}

Patch Set 1 #

Patch Set 2 : Removed an unnecessary TODO #

Patch Set 3 : Avoid a new static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -127 lines) Patch
M content/renderer/browser_plugin/browser_plugin_manager.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.h View 2 chunks +38 lines, -30 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 3 chunks +97 lines, -88 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_container.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Fady Samuel
6 years ago (2014-11-27 18:14:37 UTC) #2
paulmeyer
lgtm
6 years ago (2014-11-27 18:50:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765843003/20001
6 years ago (2014-11-27 19:15:48 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-11-27 19:15:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765843003/20001
6 years ago (2014-11-27 19:20:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-27 20:21:07 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d397750f3e2e53f414a4798c4e5039837a8c00ea Cr-Commit-Position: refs/heads/master@{#306025}
6 years ago (2014-11-27 20:21:45 UTC) #11
danakj
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/764863003/ by danakj@chromium.org. ...
6 years ago (2014-11-28 03:31:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765843003/40001
6 years ago (2014-11-28 16:41:09 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-11-28 17:53:20 UTC) #15
commit-bot: I haz the power
6 years ago (2014-11-28 17:54:03 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d0ff598d6d604ba3ac0cc940c27d5898c2640658
Cr-Commit-Position: refs/heads/master@{#306101}

Powered by Google App Engine
This is Rietveld 408576698