Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 765843003: Refactor GuestViewContainer::AttachRequest to allow for other request types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avoid a new static Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/guest_view/guest_view_container.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
index 69f70e84fe35a09534a279063771d5a0e934e2f6..86ba4ed9f19d68e5feb918afa49f274964795c2a 100644
--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
@@ -44,8 +44,7 @@ void GuestViewInternalCustomBindings::AttachGuest(
// An element instance ID uniquely identifies a ExtensionsGuestViewContainer
// within a RenderView.
ExtensionsGuestViewContainer* guest_view_container =
- ExtensionsGuestViewContainer::FromID(
- context()->GetRenderView()->GetRoutingID(), element_instance_id);
+ ExtensionsGuestViewContainer::FromID(element_instance_id);
// TODO(fsamuel): Should we be reporting an error if the element instance ID
// is invalid?
@@ -64,15 +63,15 @@ void GuestViewInternalCustomBindings::AttachGuest(
static_cast<base::DictionaryValue*>(params_as_value.release()));
}
- linked_ptr<ExtensionsGuestViewContainer::AttachRequest> request(
+ linked_ptr<ExtensionsGuestViewContainer::Request> request(
new ExtensionsGuestViewContainer::AttachRequest(
- element_instance_id,
+ guest_view_container,
guest_instance_id,
params.Pass(),
args.Length() == 4 ? args[3].As<v8::Function>() :
v8::Handle<v8::Function>(),
args.GetIsolate()));
- guest_view_container->AttachGuest(request);
+ guest_view_container->IssueRequest(request);
args.GetReturnValue().Set(v8::Boolean::New(context()->isolate(), true));
}
« no previous file with comments | « extensions/renderer/guest_view/guest_view_container.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698