content/renderer/browser_plugin/browser_plugin_manager.cc - Issue 765843003: Refactor GuestViewContainer::AttachRequest to allow for other request types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager.cc

Issue 765843003: Refactor GuestViewContainer::AttachRequest to allow for other request types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoid a new static Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/browser_plugin/browser_plugin_manager.h ('k') | extensions/renderer/guest_view/extensions_guest_view_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin_manager.cc

diff --git a/content/renderer/browser_plugin/browser_plugin_manager.cc b/content/renderer/browser_plugin/browser_plugin_manager.cc

index 16cc98e00092dff91f79eeb6c6491d24104359d1..7676aef009f0449ccdc7526dc81b8910e6fa6ee5 100644

--- a/content/renderer/browser_plugin/browser_plugin_manager.cc

+++ b/content/renderer/browser_plugin/browser_plugin_manager.cc

@@ -23,7 +23,6 @@ BrowserPluginManager* BrowserPluginManager::Create(

BrowserPluginManager::BrowserPluginManager(RenderViewImpl* render_view)

: RenderViewObserver(render_view),

- current_instance_id_(browser_plugin::kInstanceIDNone),

render_view_(render_view->AsWeakPtr()) {

}

@@ -46,7 +45,7 @@ BrowserPlugin* BrowserPluginManager::GetBrowserPlugin(

}

int BrowserPluginManager::GetNextInstanceID() {

- return ++current_instance_id_;

+ return RenderThread::Get()->GenerateRoutingID();

}

void BrowserPluginManager::UpdateDeviceScaleFactor() {