Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 765523002: Specialize InsertionPoint attach/detach. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Specialize InsertionPoint attach/detach. This is another step towards making attach non-virtual. InsertionPoints are core to the engine, so it seems fine to bake them directly into recalcStyle. I did this already to willRecalcStyle. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/29644b16d367877e96ad668d55240b99cf8076e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M sky/engine/core/dom/Element.h View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M sky/engine/core/dom/shadow/InsertionPoint.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/shadow/InsertionPoint.cpp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm
6 years ago (2014-11-26 19:39:19 UTC) #2
esprehn
6 years ago (2014-11-26 19:40:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29644b16d367877e96ad668d55240b99cf8076e0.

Powered by Google App Engine
This is Rietveld 408576698