Issue 765523002: Specialize InsertionPoint attach/detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 765523002: Specialize InsertionPoint attach/detach. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Specialize InsertionPoint attach/detach. This is another step towards making attach non-virtual. InsertionPoints are core to the engine, so it seems fine to bake them directly into recalcStyle. I did this already to willRecalcStyle. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/29644b16d367877e96ad668d55240b99cf8076e0

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
M	sky/engine/core/dom/Element.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/shadow/InsertionPoint.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/shadow/InsertionPoint.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

6 years ago (2014-11-26 19:40:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
29644b16d367877e96ad668d55240b99cf8076e0.