Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: sky/engine/core/dom/shadow/InsertionPoint.cpp

Issue 765523002: Specialize InsertionPoint attach/detach. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/shadow/InsertionPoint.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/shadow/InsertionPoint.cpp
diff --git a/sky/engine/core/dom/shadow/InsertionPoint.cpp b/sky/engine/core/dom/shadow/InsertionPoint.cpp
index 98ec9d2b2a80e58d42dcec88f48bc6b542db256a..1ac84d70647bc09d29bf14768c794c8846061e67 100644
--- a/sky/engine/core/dom/shadow/InsertionPoint.cpp
+++ b/sky/engine/core/dom/shadow/InsertionPoint.cpp
@@ -92,7 +92,7 @@ void InsertionPoint::setDistribution(ContentDistribution& distribution)
m_distribution.shrinkToFit();
}
-void InsertionPoint::attach(const AttachContext& context)
+void InsertionPoint::attachDistribution(const AttachContext& context)
{
// We need to attach the distribution here so that they're inserted in the right order
// otherwise the n^2 protection inside RenderTreeBuilder will cause them to be
@@ -102,16 +102,12 @@ void InsertionPoint::attach(const AttachContext& context)
if (m_distribution.at(i)->needsAttach())
m_distribution.at(i)->attach(context);
}
-
- HTMLElement::attach(context);
}
-void InsertionPoint::detach(const AttachContext& context)
+void InsertionPoint::detachDistribution(const AttachContext& context)
{
for (size_t i = 0; i < m_distribution.size(); ++i)
m_distribution.at(i)->lazyReattachIfAttached();
-
- HTMLElement::detach(context);
}
void InsertionPoint::willRecalcStyle(StyleRecalcChange change)
« no previous file with comments | « sky/engine/core/dom/shadow/InsertionPoint.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698