Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2695)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
index fb35ebb2b5c7aab85ab9f0004f38beec859ceaa7..efff1bbda43a2b40ba76651a9b484182207fedd4 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
@@ -228,7 +228,14 @@ TEST_F(ChromePasswordManagerClientTest,
ChromePasswordManagerClient* client = GetClient();
// TODO(melandory) Since "Ask user to submit URL" functionality is currently
// in development, so the user should not be asked to submit a URL.
- EXPECT_FALSE(client->ShouldAskUserToSubmitURL());
+ EXPECT_FALSE(client->ShouldAskUserToSubmitURL(GURL("https://hostname.com/")));
+}
+
+TEST_F(ChromePasswordManagerClientTest, ShouldAskUserToSubmitURLEmptyURL) {
+ ChromePasswordManagerClient* client = GetClient();
+ // TODO(melandory) Since "Ask user to submit URL" functionality is currently
vabr (Chromium) 2014/12/04 13:25:32 The TODO comment here seems like a copy&paste mist
melandory 2014/12/05 12:56:52 Done.
+ // in development, so the user should not be asked to submit a URL.
+ EXPECT_FALSE(client->ShouldAskUserToSubmitURL(GURL::EmptyGURL()));
}
TEST_F(ChromePasswordManagerClientTest, ShouldFilterAutofillResult_Reauth) {

Powered by Google App Engine
This is Rietveld 408576698