Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/command_line.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
@@ skipping 210 matching lines @@
 
   service_->UnregisterReceiver(&receiver_);
   EXPECT_FALSE(client->IsLoggingActive());
 }
 
 TEST_F(ChromePasswordManagerClientTest,
        ShouldAskUserToSubmitURLDefaultBehaviour) {
   ChromePasswordManagerClient* client = GetClient();
   // TODO(melandory) Since "Ask user to submit URL" functionality is currently
   // in development, so the user should not be asked to submit a URL.
-  EXPECT_FALSE(client->ShouldAskUserToSubmitURL());
+  EXPECT_FALSE(client->ShouldAskUserToSubmitURL(GURL("https://hostname.com/")));
+}
+
+TEST_F(ChromePasswordManagerClientTest, ShouldAskUserToSubmitURLEmptyURL) {
+  ChromePasswordManagerClient* client = GetClient();
+  // TODO(melandory) Since "Ask user to submit URL" functionality is currently

[vabr (Chromium), 2014/12/04 13:25:32]

The TODO comment here seems like a copy&paste mistake. Here we should always
EXPECT_FALSE, no?

[melandory, 2014/12/05 12:56:52]

Done.

+  // in development, so the user should not be asked to submit a URL.
+  EXPECT_FALSE(client->ShouldAskUserToSubmitURL(GURL::EmptyGURL()));
 }
 
 TEST_F(ChromePasswordManagerClientTest, ShouldFilterAutofillResult_Reauth) {
   // Make client disallow only reauth requests.
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   command_line->AppendSwitch(
       password_manager::switches::kDisallowAutofillSyncCredentialForReauth);
   scoped_ptr<TestChromePasswordManagerClient> client(
       new TestChromePasswordManagerClient(web_contents()));
   autofill::PasswordForm form;
@@ skipping 147 matching lines @@
 
   // Again, without a custom passphrase.
   EXPECT_CALL(*mock_sync_service, IsUsingSecondaryPassphrase())
       .WillRepeatedly(Return(false));
 
   EXPECT_FALSE(
       client->IsPasswordSyncEnabled(password_manager::ONLY_CUSTOM_PASSPHRASE));
   EXPECT_FALSE(client->IsPasswordSyncEnabled(
       password_manager::WITHOUT_CUSTOM_PASSPHRASE));
 }