Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7323)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index 8674be851ab35b5aaedf2033721a259556aacd82..811818723994480a63712842df3b7b91bdf0f83e 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -40,6 +40,12 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// Called by the view code when the bubble is hidden.
void OnBubbleHidden();
+ // Call by the view code when user agreed for URL collection.
vabr (Chromium) 2014/12/04 13:25:33 grammar nit: agreed for -> agreed to
melandory 2014/12/05 12:56:52 Done.
+ void OnCollectURLClicked();
+
+ // Called by the view code when user didn't allow to collect URL.
+ void OnDoNotCollectURLClicked();
+
// Called by the view code when the "Nope" button in clicked by the user.
void OnNopeClicked();
@@ -70,6 +76,8 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// Called by the view code to notify about chosen credential.
void OnChooseCredentials(const autofill::PasswordForm& password_form);
+ GURL origin() const { return origin_; }
+
password_manager::ui::State state() const { return state_; }
const base::string16& title() const { return title_; }
@@ -111,6 +119,8 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
static int PasswordFieldWidth();
private:
+ // URL of a page from where bubble was triggered.
vabr (Chromium) 2014/12/04 13:25:33 grammar nits: a page -> the page bubble -> this bu
melandory 2014/12/05 12:56:52 Done.
+ GURL origin_;
password_manager::ui::State state_;
base::string16 title_;
autofill::PasswordForm pending_password_;

Powered by Google App Engine
This is Rietveld 408576698