Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3295)

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nit. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/command_updater.h ('K') | « chrome/browser/ui/browser_commands.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/bubble_icon_view.cc
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
index d74f32937b6aa3edd0a181bb149c653e97b45caf..7662d04e7a8223272d1d88582bd0a8aad22e4483 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
@@ -71,6 +71,9 @@ void BubbleIconView::OnGestureEvent(ui::GestureEvent* event) {
void BubbleIconView::ExecuteCommand(ExecuteSource source) {
OnExecuting(source);
- if (command_updater_)
+ if (command_updater_) {
+ command_updater_->set_bookmark_icon_selected(true);
command_updater_->ExecuteCommand(command_id_);
+ command_updater_->set_bookmark_icon_selected(false);
+ }
}
« chrome/browser/command_updater.h ('K') | « chrome/browser/ui/browser_commands.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698