Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nit. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index b289ec114e1dd77b78f6e1ff53f46c4e65fa069c..77a16de52c0e26e2651e179c1173964fe70746ce 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -748,10 +748,11 @@ void BookmarkCurrentPage(Browser* browser) {
const extensions::Extension* extension = NULL;
extensions::Command command;
extensions::CommandService::ExtensionCommandType command_type;
- if (GetBookmarkOverrideCommand(browser->profile(),
- &extension,
- &command,
- &command_type)) {
+ if (GetBookmarkOverrideCommand(browser->profile(), &extension, &command,
+ &command_type) &&
+ !browser->command_controller()
+ ->command_updater()
+ ->get_bookmark_icon_selected()) {
switch (command_type) {
case extensions::CommandService::NAMED:
browser->window()->ExecuteExtensionCommand(extension, command);

Powered by Google App Engine
This is Rietveld 408576698