Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nit. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h" 5 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"
6 6
7 #include "chrome/browser/command_updater.h" 7 #include "chrome/browser/command_updater.h"
8 #include "ui/accessibility/ax_view_state.h" 8 #include "ui/accessibility/ax_view_state.h"
9 #include "ui/events/event.h" 9 #include "ui/events/event.h"
10 10
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 void BubbleIconView::OnGestureEvent(ui::GestureEvent* event) { 65 void BubbleIconView::OnGestureEvent(ui::GestureEvent* event) {
66 if (event->type() == ui::ET_GESTURE_TAP) { 66 if (event->type() == ui::ET_GESTURE_TAP) {
67 ExecuteCommand(EXECUTE_SOURCE_GESTURE); 67 ExecuteCommand(EXECUTE_SOURCE_GESTURE);
68 event->SetHandled(); 68 event->SetHandled();
69 } 69 }
70 } 70 }
71 71
72 void BubbleIconView::ExecuteCommand(ExecuteSource source) { 72 void BubbleIconView::ExecuteCommand(ExecuteSource source) {
73 OnExecuting(source); 73 OnExecuting(source);
74 if (command_updater_) 74 if (command_updater_) {
75 command_updater_->set_bookmark_icon_selected(true);
75 command_updater_->ExecuteCommand(command_id_); 76 command_updater_->ExecuteCommand(command_id_);
77 command_updater_->set_bookmark_icon_selected(false);
78 }
76 } 79 }
OLDNEW
« chrome/browser/command_updater.h ('K') | « chrome/browser/ui/browser_commands.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698