chrome/browser/command_updater.cc - Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/command_updater.cc

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nit. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/command_updater.cc

diff --git a/chrome/browser/command_updater.cc b/chrome/browser/command_updater.cc

index 4eb8391711f0c51ae8f5a74f79744dfa44d350be..f4cbc6d3f2bd4c7a7425df6b2fb7c003551bae20 100644

--- a/chrome/browser/command_updater.cc

+++ b/chrome/browser/command_updater.cc

@@ -21,7 +21,7 @@ class CommandUpdater::Command {

};

CommandUpdater::CommandUpdater(CommandUpdaterDelegate* delegate)

- : delegate_(delegate) {

+ : delegate_(delegate), bookmark_icon_selection_(false) {

}

CommandUpdater::~CommandUpdater() {

« chrome/browser/command_updater.h ('K') | « chrome/browser/command_updater.h ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »