chrome/browser/ui/views/location_bar/star_view.h - Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/star_view.h

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/location_bar/star_view.cc » ('j') | chrome/browser/ui/views/location_bar/star_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/star_view.h

diff --git a/chrome/browser/ui/views/location_bar/star_view.h b/chrome/browser/ui/views/location_bar/star_view.h

index 58f4f2e661a74a195f7086c2d9efaa51dce51cc5..94e69c78c9227c09339ed88ffe84aad087abe8cb 100644

--- a/chrome/browser/ui/views/location_bar/star_view.h

+++ b/chrome/browser/ui/views/location_bar/star_view.h

@@ -7,12 +7,12 @@

#include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"

-class CommandUpdater;

+class Browser;

// The star icon to show a bookmark bubble.

class StarView : public BubbleIconView {

public:

- explicit StarView(CommandUpdater* command_updater);

+ explicit StarView(Browser* browser);

~StarView() override;

// Toggles the star on or off.

@@ -22,8 +22,10 @@ class StarView : public BubbleIconView {

// BubbleIconView:

bool IsBubbleShowing() const override;

void OnExecuting(BubbleIconView::ExecuteSource execute_source) override;

+ void ExecuteCommand(ExecuteSource source) override;

private:

+ Browser* browser_;

tfarina 2014/12/12 21:54:23 please, add a blank line after this.

Deepak 2014/12/13 03:36:54 Done.

DISALLOW_COPY_AND_ASSIGN(StarView);

};