Index: chrome/browser/ui/views/location_bar/star_view.cc |
diff --git a/chrome/browser/ui/views/location_bar/star_view.cc b/chrome/browser/ui/views/location_bar/star_view.cc |
index b5627a0735b8f05de2d9878e4d76c22a671103dd..77d5ecc3dc6874beb426d8928c56fc05a26366a4 100644 |
--- a/chrome/browser/ui/views/location_bar/star_view.cc |
+++ b/chrome/browser/ui/views/location_bar/star_view.cc |
@@ -8,6 +8,9 @@ |
#include "base/strings/utf_string_conversions.h" |
#include "chrome/app/chrome_command_ids.h" |
#include "chrome/browser/bookmarks/bookmark_stats.h" |
+#include "chrome/browser/ui/browser.h" |
+#include "chrome/browser/ui/browser_command_controller.h" |
+#include "chrome/browser/ui/browser_commands.h" |
#include "chrome/browser/ui/view_ids.h" |
#include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h" |
#include "chrome/grit/generated_resources.h" |
@@ -15,8 +18,10 @@ |
#include "ui/base/l10n/l10n_util.h" |
#include "ui/base/resource/resource_bundle.h" |
-StarView::StarView(CommandUpdater* command_updater) |
- : BubbleIconView(command_updater, IDC_BOOKMARK_PAGE) { |
+StarView::StarView(Browser* browser) |
+ : BubbleIconView(browser->command_controller()->command_updater(), |
+ IDC_BOOKMARK_PAGE) { |
+ browser_ = browser; |
Mike Wittman
2014/12/12 20:41:57
Nit: move to initializer list.
Deepak
2014/12/13 03:36:53
Done.
|
set_id(VIEW_ID_STAR_BUTTON); |
SetToggled(false); |
} |
@@ -52,3 +57,9 @@ void StarView::OnExecuting( |
entry_point, |
BOOKMARK_ENTRY_POINT_LIMIT); |
} |
+ |
+void StarView::ExecuteCommand(ExecuteSource source) { |
+ OnExecuting(source); |
+ if (browser_) |
Mike Wittman
2014/12/12 20:41:57
Nit: you're already depending on browser to be non
Peter Kasting
2014/12/12 21:49:05
Actually, it turns out I was wrong about it always
Deepak
2014/12/13 03:36:53
Done.
Deepak
2014/12/13 03:36:54
For considering Peter's advice, I need this if che
|
+ chrome::BookmarkCurrentPageIgnoringExtensionOverrides(browser_); |
+} |