Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: chrome/browser/ui/views/location_bar/star_view.h

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_
7 7
8 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h" 8 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"
9 9
10 class CommandUpdater; 10 class Browser;
11 11
12 // The star icon to show a bookmark bubble. 12 // The star icon to show a bookmark bubble.
13 class StarView : public BubbleIconView { 13 class StarView : public BubbleIconView {
14 public: 14 public:
15 explicit StarView(CommandUpdater* command_updater); 15 explicit StarView(Browser* browser);
16 ~StarView() override; 16 ~StarView() override;
17 17
18 // Toggles the star on or off. 18 // Toggles the star on or off.
19 void SetToggled(bool on); 19 void SetToggled(bool on);
20 20
21 protected: 21 protected:
22 // BubbleIconView: 22 // BubbleIconView:
23 bool IsBubbleShowing() const override; 23 bool IsBubbleShowing() const override;
24 void OnExecuting(BubbleIconView::ExecuteSource execute_source) override; 24 void OnExecuting(BubbleIconView::ExecuteSource execute_source) override;
25 void ExecuteCommand(ExecuteSource source) override;
25 26
26 private: 27 private:
28 Browser* browser_;
tfarina 2014/12/12 21:54:23 please, add a blank line after this.
Deepak 2014/12/13 03:36:54 Done.
27 DISALLOW_COPY_AND_ASSIGN(StarView); 29 DISALLOW_COPY_AND_ASSIGN(StarView);
28 }; 30 };
29 31
30 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_ 32 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698