chrome/browser/ui/browser_commands.h - Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.h

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_commands.h

diff --git a/chrome/browser/ui/browser_commands.h b/chrome/browser/ui/browser_commands.h

index b677e7d54608e43bfe3200a2ccd459548e80644f..497935af5d1abc3e19b6a3fd0c6976b46f23ac9c 100644

--- a/chrome/browser/ui/browser_commands.h

+++ b/chrome/browser/ui/browser_commands.h

@@ -27,7 +27,7 @@ struct SSLStatus;

namespace chrome {

// For all commands, where a tab is not specified, the active tab is assumed.

+void BookmarkCurrentPageInternal(Browser* browser);

Peter Kasting 2014/12/12 01:20:56 Nit: List this just below the other bookmarking-re

Deepak 2014/12/12 06:49:46 Done.

bool IsCommandEnabled(Browser* browser, int command);

bool SupportsCommand(Browser* browser, int command);

bool ExecuteCommand(Browser* browser, int command);

« no previous file with comments | « no previous file | chrome/browser/ui/browser_commands.cc » ('j') | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('J')