Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/browser_commands.h

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMANDS_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMANDS_H_
6 #define CHROME_BROWSER_UI_BROWSER_COMMANDS_H_ 6 #define CHROME_BROWSER_UI_BROWSER_COMMANDS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "chrome/browser/devtools/devtools_toggle_action.h" 10 #include "chrome/browser/devtools/devtools_toggle_action.h"
11 #include "chrome/browser/ui/host_desktop.h" 11 #include "chrome/browser/ui/host_desktop.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model_delegate.h" 12 #include "chrome/browser/ui/tabs/tab_strip_model_delegate.h"
13 #include "content/public/common/page_zoom.h" 13 #include "content/public/common/page_zoom.h"
14 #include "ui/base/window_open_disposition.h" 14 #include "ui/base/window_open_disposition.h"
15 15
16 class Browser; 16 class Browser;
17 class CommandObserver; 17 class CommandObserver;
18 class GURL; 18 class GURL;
19 class Profile; 19 class Profile;
20 20
21 namespace content { 21 namespace content {
22 class PageState; 22 class PageState;
23 class WebContents; 23 class WebContents;
24 struct SSLStatus; 24 struct SSLStatus;
25 } 25 }
26 26
27 namespace chrome { 27 namespace chrome {
28 28
29 // For all commands, where a tab is not specified, the active tab is assumed. 29 // For all commands, where a tab is not specified, the active tab is assumed.
30 30 void BookmarkCurrentPageInternal(Browser* browser);
Peter Kasting 2014/12/12 01:20:56 Nit: List this just below the other bookmarking-re
Deepak 2014/12/12 06:49:46 Done.
31 bool IsCommandEnabled(Browser* browser, int command); 31 bool IsCommandEnabled(Browser* browser, int command);
32 bool SupportsCommand(Browser* browser, int command); 32 bool SupportsCommand(Browser* browser, int command);
33 bool ExecuteCommand(Browser* browser, int command); 33 bool ExecuteCommand(Browser* browser, int command);
34 bool ExecuteCommandWithDisposition(Browser* browser, 34 bool ExecuteCommandWithDisposition(Browser* browser,
35 int command, 35 int command,
36 WindowOpenDisposition disposition); 36 WindowOpenDisposition disposition);
37 void UpdateCommandEnabled(Browser* browser, int command, bool enabled); 37 void UpdateCommandEnabled(Browser* browser, int command, bool enabled);
38 void AddCommandObserver(Browser*, int command, CommandObserver* observer); 38 void AddCommandObserver(Browser*, int command, CommandObserver* observer);
39 void RemoveCommandObserver(Browser*, int command, CommandObserver* observer); 39 void RemoveCommandObserver(Browser*, int command, CommandObserver* observer);
40 40
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 void CreateApplicationShortcuts(Browser* browser); 166 void CreateApplicationShortcuts(Browser* browser);
167 void CreateBookmarkAppFromCurrentWebContents(Browser* browser); 167 void CreateBookmarkAppFromCurrentWebContents(Browser* browser);
168 bool CanCreateApplicationShortcuts(const Browser* browser); 168 bool CanCreateApplicationShortcuts(const Browser* browser);
169 bool CanCreateBookmarkApp(const Browser* browser); 169 bool CanCreateBookmarkApp(const Browser* browser);
170 170
171 void ConvertTabToAppWindow(Browser* browser, content::WebContents* contents); 171 void ConvertTabToAppWindow(Browser* browser, content::WebContents* contents);
172 172
173 } // namespace chrome 173 } // namespace chrome
174 174
175 #endif // CHROME_BROWSER_UI_BROWSER_COMMANDS_H_ 175 #endif // CHROME_BROWSER_UI_BROWSER_COMMANDS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser_commands.cc » ('j') | chrome/browser/ui/views/location_bar/bubble_icon_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698