Issue 764573002: Parametrize PageScriptDebugServer with v8::Context -> InspectorHost resolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 764573002: Parametrize PageScriptDebugServer with v8::Context -> InspectorHost resolver (Closed)

Created:
6 years ago by yurys

Modified:
6 years ago

Reviewers:
abarth-chromium, eseidel

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Parametrize PageScriptDebugServer with v8::Context -> InspectorHost resolver ScriptDebugServer needs a way to find ScriptDebugListener for the paused v8::Context. The listeners are added per InspectorHost. Now we have to mapping v8::Context -> InspectorHost, InspectorHost -> ScriptDebugListener which allow to map v8::Context -> ScriptDebugListener. This allows to avoid storing InspectorHost on Page. BUG=435243 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/290d8e5342b150d96ec30efba78fddba6129d01f

Patch Set 1 #

Patch Set 2 : Removed Page::m_inspectorHost #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -19 lines)			Patch
M	sky/engine/core/page/Page.h	View	1	3 chunks	+0 lines, -11 lines	0 comments	Download
M	sky/engine/core/page/Page.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/v8_inspector/PageScriptDebugServer.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	sky/engine/v8_inspector/PageScriptDebugServer.cpp	View		2 chunks	+10 lines, -7 lines	0 comments	Download
M	sky/engine/v8_inspector/inspector_backend_mojo.cc	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

yurys

6 years ago (2014-11-27 08:18:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
290d8e5342b150d96ec30efba78fddba6129d01f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages