Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: sky/engine/v8_inspector/PageScriptDebugServer.h

Issue 764573002: Parametrize PageScriptDebugServer with v8::Context -> InspectorHost resolver (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Removed Page::m_inspectorHost Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/page/Page.cpp ('k') | sky/engine/v8_inspector/PageScriptDebugServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/v8_inspector/PageScriptDebugServer.h
diff --git a/sky/engine/v8_inspector/PageScriptDebugServer.h b/sky/engine/v8_inspector/PageScriptDebugServer.h
index 351145387c4228d4baf9df23f0a572065a854940..03d6d1e7e0d984d0a309a27f491b3d1cc3196bf9 100644
--- a/sky/engine/v8_inspector/PageScriptDebugServer.h
+++ b/sky/engine/v8_inspector/PageScriptDebugServer.h
@@ -68,6 +68,13 @@ public:
};
void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);
+ class InspectorHostResolver {
+ public:
+ virtual ~InspectorHostResolver() { }
+ virtual inspector::InspectorHost* inspectorHostFor(v8::Handle<v8::Context>) = 0;
+ };
+ void setInspectorHostResolver(PassOwnPtr<InspectorHostResolver>);
+
virtual void compileScript(ScriptState*, const String& expression, const String& sourceURL, String* scriptId, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtr<ScriptCallStack>* stackTrace) override;
virtual void clearCompiledScripts() override;
virtual void runScript(ScriptState*, const String& scriptId, ScriptValue* result, bool* wasThrown, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtr<ScriptCallStack>* stackTrace) override;
@@ -91,6 +98,7 @@ private:
typedef HashMap<inspector::InspectorHost*, ScriptDebugListener*> ListenersMap;
ListenersMap m_listenersMap;
OwnPtr<ClientMessageLoop> m_clientMessageLoop;
+ OwnPtr<InspectorHostResolver> m_inspectorHostResolver;
inspector::InspectorHost* m_pausedHost;
HashMap<String, String> m_compiledScriptURLs;
« no previous file with comments | « sky/engine/core/page/Page.cpp ('k') | sky/engine/v8_inspector/PageScriptDebugServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698