Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: sky/engine/core/page/Page.h

Issue 764573002: Parametrize PageScriptDebugServer with v8::Context -> InspectorHost resolver (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Removed Page::m_inspectorHost Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/page/Page.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/page/Page.h
diff --git a/sky/engine/core/page/Page.h b/sky/engine/core/page/Page.h
index 616d88a24b953971fbc1110e97bfb4b4a07b8a05..92aab8d7145c96422fbd03f58a52109e95b21f54 100644
--- a/sky/engine/core/page/Page.h
+++ b/sky/engine/core/page/Page.h
@@ -36,11 +36,6 @@
#include "sky/engine/wtf/Noncopyable.h"
#include "sky/engine/wtf/text/WTFString.h"
-// FIXME: Page should not need to know anything about InspectorHost.
-namespace inspector {
-class InspectorHost;
-}
-
namespace blink {
class AutoscrollController;
@@ -90,11 +85,6 @@ public:
FrameHost& frameHost() const { return *m_frameHost; }
- // FIXME(sky): This is only needed by PageDebuggerAgent to be able to look
- // up the InspectorHost from the frame associated with a v8 context.
- inspector::InspectorHost* inspectorHost() const { return m_inspectorHost; }
- void setInspectorHost(inspector::InspectorHost* host) { m_inspectorHost = host; }
-
void setNeedsRecalcStyleInAllFrames();
void updateAcceleratedCompositingSettings();
@@ -217,7 +207,6 @@ private:
// A pointer to all the interfaces provided to in-process Frames for this Page.
// FIXME: Most of the members of Page should move onto FrameHost.
OwnPtr<FrameHost> m_frameHost;
- inspector::InspectorHost* m_inspectorHost;
};
} // namespace blink
« no previous file with comments | « no previous file | sky/engine/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698