content/browser/tracing/trace_uploader.cc - Issue 763833003: Remove using namespace in net/quic/quic_stream_sequencer.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/trace_uploader.cc

Issue 763833003: Remove using namespace in net/quic/quic_stream_sequencer.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/resource_scheduler_unittest.cc ('k') | google_apis/drive/drive_api_requests_unittest.cc » ('j') | net/quic/congestion_control/send_algorithm_simulator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tracing/trace_uploader.cc

diff --git a/content/browser/tracing/trace_uploader.cc b/content/browser/tracing/trace_uploader.cc

index 3bcc1872817a9f040c2387a380871d797d67d872..4a2a5998b9cc2a682b194d12054bbfc5367d7e98 100644

--- a/content/browser/tracing/trace_uploader.cc

+++ b/content/browser/tracing/trace_uploader.cc

@@ -4,6 +4,8 @@

#include "content/browser/tracing/trace_uploader.h"

+#include <string>

#include "base/files/file_path.h"

#include "base/files/file_util.h"

#include "base/memory/shared_memory.h"

@@ -53,8 +55,8 @@ void TraceUploader::OnURLFetchComplete(const net::URLFetcher* source) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK_EQ(source, url_fetcher_.get());

int response_code = source->GetResponseCode();

- string report_id;

- string error_message;

+ std::string report_id;

+ std::string error_message;

bool success = (response_code == kHttpResponseOk);

if (success) {

source->GetResponseAsString(&report_id);