Remove using namespace in net/quic/quic_stream_sequencer.h

net/quic/congestion_control/send_algorithm_simulator.cc

Index: net/quic/congestion_control/send_algorithm_simulator.cc
diff --git a/net/quic/congestion_control/send_algorithm_simulator.cc b/net/quic/congestion_control/send_algorithm_simulator.cc
index 765394342fbaf0c8cee6006480fa820438d4abc5..e33445c80d669399f116218fb530bfe2913fc820 100644
--- a/net/quic/congestion_control/send_algorithm_simulator.cc
+++ b/net/quic/congestion_control/send_algorithm_simulator.cc
@@ -5,6 +5,7 @@
 #include "net/quic/congestion_control/send_algorithm_simulator.h"
 
 #include <limits>
+#include <string>
 
 #include "base/logging.h"
 #include "base/rand_util.h"
@@ -47,7 +48,7 @@ SendAlgorithmSimulator::Sender::Sender(SendAlgorithmInterface* send_algorithm,
 SendAlgorithmSimulator::Transfer::Transfer(Sender* sender,
                                            QuicByteCount num_bytes,
                                            QuicTime start_time,
-                                           string name)
+                                           std::string name)

[ramant (doing other things), 2014/12/02 04:14:43]

We share net/quic and net/tools/quic code with internal source and merging
becomes harder for every line that has "std::string".

Is it possible to add "using std::string;" and delete all changes that add
"std::"?

We use "using std::string;" construct at other places in chromium codebase.

https://code.google.com/p/chromium/codesearch#search/&q=%22using%20std::strin...

Thanks.

[haltonhuo, 2014/12/02 04:57:07]

Does that make sense that adding "using std::string;" for .cc and add "std::"
for .h?
I guess you agree that "using std" in header is bad behavior, do you want to
change in this CL or separate one?

[ramant (doing other things), 2014/12/03 01:10:09]

We use "std::" in the header files (we don't specify "using ..." in .h files).

     : sender(sender),
       num_bytes(num_bytes),
       bytes_acked(0),
@@ -82,7 +83,7 @@ void SendAlgorithmSimulator::AddTransfer(Sender* sender, size_t num_bytes) {
 }
 
 void SendAlgorithmSimulator::AddTransfer(
-    Sender* sender, size_t num_bytes, QuicTime start_time, string name) {
+    Sender* sender, size_t num_bytes, QuicTime start_time, std::string name) {
   pending_transfers_.push_back(Transfer(sender, num_bytes, start_time, name));
   // Record initial stats from when the transfer begins.
   pending_transfers_.back().sender->RecordStats();