Remove using namespace in net/quic/quic_stream_sequencer.h

Remove using namespace in net/quic/quic_stream_sequencer.h

Using namespace in a header file is very dangerous since then by
including that header in another file I will get the namespace
imported into that file as well, so remove that usage and modify
related files.

BUG=None
TEST=build all target

Committed: https://crrev.com/e4e4574043067c1f92bbf64b0c27e33c72d23be8
Cr-Commit-Position: refs/heads/master@{#307211}

[haltonhuo, 2014-11-28 08:55:31]

This CL need work together with https://codereview.appspot.com/183860043/,
please review.

[haltonhuo, 2014-12-02 03:41:28]

halton.huo@intel.com changed reviewers:
+ rtenneti@google.com

[haltonhuo, 2014-12-02 03:41:29]

rtenneti, could you review this CL?

[ramant (doing other things), 2014-12-02 03:42:11]

rtenneti@chromium.org changed reviewers:
+ rch@chromium.org

[ramant (doing other things), 2014-12-02 03:55:35]

rtenneti@chromium.org changed reviewers:
+ rtenneti@chromium.org
- rtenneti@google.com

[ramant (doing other things), 2014-12-02 04:14:43]

https://codereview.chromium.org/763833003/diff/1/net/quic/congestion_control/...
File net/quic/congestion_control/send_algorithm_simulator.cc (right):

https://codereview.chromium.org/763833003/diff/1/net/quic/congestion_control/...
net/quic/congestion_control/send_algorithm_simulator.cc:51: std::string name)
We share net/quic and net/tools/quic code with internal source and merging
becomes harder for every line that has "std::string".

Is it possible to add "using std::string;" and delete all changes that add
"std::"?

We use "using std::string;" construct at other places in chromium codebase.

https://code.google.com/p/chromium/codesearch#search/&q=%22using%20std::strin...

Thanks.

[haltonhuo, 2014-12-02 04:57:07]

https://codereview.chromium.org/763833003/diff/1/net/quic/congestion_control/...
File net/quic/congestion_control/send_algorithm_simulator.cc (right):

https://codereview.chromium.org/763833003/diff/1/net/quic/congestion_control/...
net/quic/congestion_control/send_algorithm_simulator.cc:51: std::string name)
On 2014/12/02 04:14:43, ramant wrote:
> We share net/quic and net/tools/quic code with internal source and merging
> becomes harder for every line that has "std::string".
> 
> Is it possible to add "using std::string;" and delete all changes that add
"std::"?

Does that make sense that adding "using std::string;" for .cc and add "std::"
for .h?
> 
> We use "using std::string;" construct at other places in chromium codebase.
> 
>
https://code.google.com/p/chromium/codesearch#search/&q=%22using%20std::strin...

I guess you agree that "using std" in header is bad behavior, do you want to
change in this CL or separate one?

[ramant (doing other things), 2014-12-03 01:10:09]

https://codereview.chromium.org/763833003/diff/1/net/quic/congestion_control/...
File net/quic/congestion_control/send_algorithm_simulator.cc (right):

https://codereview.chromium.org/763833003/diff/1/net/quic/congestion_control/...
net/quic/congestion_control/send_algorithm_simulator.cc:51: std::string name)
On 2014/12/02 04:57:07, haltonhuo wrote:
> On 2014/12/02 04:14:43, ramant wrote:
> > We share net/quic and net/tools/quic code with internal source and merging
> > becomes harder for every line that has "std::string".
> > 
> > Is it possible to add "using std::string;" and delete all changes that add
> "std::"?
> 
> Does that make sense that adding "using std::string;" for .cc and add "std::"
> for .h?
> > 
> > We use "using std::string;" construct at other places in chromium codebase.
> > 
> >
>
https://code.google.com/p/chromium/codesearch#search/&q=%22using%20std::strin...
> 
> I guess you agree that "using std" in header is bad behavior, do you want to
> change in this CL or separate one?

We use "std::" in the header files (we don't specify "using ..." in .h files).

https://codereview.chromium.org/763833003/diff/20001/net/http/disk_cache_base...
File net/http/disk_cache_based_quic_server_info_unittest.cc (right):

https://codereview.chromium.org/763833003/diff/20001/net/http/disk_cache_base...
net/http/disk_cache_based_quic_server_info_unittest.cc:7: #include <string>
disk_cache_based_quic_server_info.h is including string. Do we need to include
it again in the disk_cache_based_quic_server_info_unittest.cc?

https://codereview.chromium.org/763833003/diff/20001/net/quic/congestion_cont...
File net/quic/congestion_control/send_algorithm_simulator.cc (right):

https://codereview.chromium.org/763833003/diff/20001/net/quic/congestion_cont...
net/quic/congestion_control/send_algorithm_simulator.cc:8: #include <string>
send_algorithm_simulator.h has included string.

https://codereview.chromium.org/763833003/diff/20001/net/quic/reliable_quic_s...
File net/quic/reliable_quic_stream.h (right):

https://codereview.chromium.org/763833003/diff/20001/net/quic/reliable_quic_s...
net/quic/reliable_quic_stream.h:13: #include <string>
We are doing "#include <string>" both in .h and .cc files that include that
file? If we include .h file, then do we need to include .cc file? (or should we
remove the include from .h file?)

https://codereview.chromium.org/763833003/diff/20001/net/tools/quic/quic_serv...
File net/tools/quic/quic_server_session.h (right):

https://codereview.chromium.org/763833003/diff/20001/net/tools/quic/quic_serv...
net/tools/quic/quic_server_session.h:11: #include <string>
we are including string in quic_server_session.h and quic_server_session_test.cc

[haltonhuo, 2014-12-03 02:49:05]

ramant, I removed the redundant include <string> in patch set3. And remove/add
some include in .h files if there is missing. Please review again.

[haltonhuo, 2014-12-03 06:56:49]

On 2014/12/03 02:49:05, haltonhuo wrote:
> ramant, I removed the redundant include <string> in patch set3. And remove/add
> some include in .h files if there is missing. Please review again.

And just let you know, https://codereview.appspot.com/183860043/ is not hard
dependency of this CL.

[ramant (doing other things), 2014-12-03 19:54:51]

LGTM for net/quic and net/tools/quic.

Thanks for making these changes.

[haltonhuo, 2014-12-04 01:31:52]

halton.huo@intel.com changed reviewers:
+ cpu@chromium.org, jam@chromium.org, kinaba@chromium.org, sky@chromium.org
- rch@chromium.org

[haltonhuo, 2014-12-04 01:31:53]

Ramant, thanks for the review for net.

Add sky for changes in chrome/
Add cpu for changes in components/
Add jam for changes in contents/
Add kinaba for changes in google_apis/drive

[kinaba, 2014-12-04 02:04:01]

https://codereview.chromium.org/763833003/diff/40001/google_apis/drive/drive_...
File google_apis/drive/drive_api_requests_unittest.cc (right):

https://codereview.chromium.org/763833003/diff/40001/google_apis/drive/drive_...
google_apis/drive/drive_api_requests_unittest.cc:26: using std::string;
The uses of unqualified 'string' are not intentional, they are just mistakes, at
least under google_apis/drive.

Rather than adding the declaration, could you replace all unqualified
occurrences of string with std::string instead? Thanks for catching this!

[haltonhuo, 2014-12-04 02:14:32]

https://codereview.chromium.org/763833003/diff/40001/google_apis/drive/drive_...
File google_apis/drive/drive_api_requests_unittest.cc (right):

https://codereview.chromium.org/763833003/diff/40001/google_apis/drive/drive_...
google_apis/drive/drive_api_requests_unittest.cc:26: using std::string;
On 2014/12/04 02:04:01, kinaba wrote:
> The uses of unqualified 'string' are not intentional, they are just mistakes,
at
> least under google_apis/drive.
> 
> Rather than adding the declaration, could you replace all unqualified
> occurrences of string with std::string instead? Thanks for catching this!

Done locally, and i removed the using std::string as well. Will upload new patch
set in case I need furthure change on other unreviewed parts.

[sky, 2014-12-04 04:27:45]

chrome/ LGTM

[jam, 2014-12-04 17:40:34]

lgtm

[cpu_(ooo_6.6-7.5), 2014-12-04 23:57:40]

lgtm

[haltonhuo, 2014-12-05 01:50:59]

kinaba, the patch set 4 is updated to fix your comment on google_apis/drive.
please take a look.

[kinaba, 2014-12-05 02:04:11]

lgtm

[haltonhuo, 2014-12-05 02:06:47]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-12-05 02:07:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763833003/60001

[commit-bot: I haz the power, 2014-12-05 02:34:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 02:34:18]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haltonhuo, 2014-12-05 02:58:42]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-12-05 02:59:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763833003/60001

[commit-bot: I haz the power, 2014-12-05 03:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 03:38:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haltonhuo, 2014-12-05 04:37:09]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-12-05 04:37:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763833003/60001

[commit-bot: I haz the power, 2014-12-05 05:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 05:14:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haltonhuo, 2014-12-05 05:55:35]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-12-05 05:56:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763833003/60001

[commit-bot: I haz the power, 2014-12-05 06:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 06:34:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haltonhuo, 2014-12-05 09:46:35]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-12-05 09:47:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763833003/60001

[haltonhuo, 2014-12-05 10:19:47]

The CQ bit was unchecked by halton.huo@intel.com

[haltonhuo, 2014-12-06 15:37:19]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-12-06 15:37:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763833003/60001

[commit-bot: I haz the power, 2014-12-06 16:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-06 16:14:57]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haltonhuo, 2014-12-08 06:40:45]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-12-08 06:41:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763833003/60001

[kinaba, 2014-12-08 06:46:40]

@haltonhuo, the failure looks real. You need some more changes.

../../chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:201:3:error:
unknown type name 'string'; did you mean 'std::string'?
  string url_fetcher_response_string_;
  ^~~~~~
  std::string
/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stringfwd.h:65:33:
note: 'std::string' declared here
  typedef basic_string<char>    string;   /// A string of @c char
                                ^
1 error generated.
ninja: build stopped: subcommand failed.

[haltonhuo, 2014-12-08 06:57:44]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-12-08 06:58:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763833003/80001

[commit-bot: I haz the power, 2014-12-08 07:55:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-12-08 07:56:32]

Patchset 5 (id:??) landed as
https://crrev.com/e4e4574043067c1f92bbf64b0c27e33c72d23be8
Cr-Commit-Position: refs/heads/master@{#307211}

[haltonhuo, 2014-12-08 07:58:43]

On 2014/12/08 06:46:40, kinaba wrote:
> @haltonhuo, the failure looks real. You need some more changes.
> 
>
../../chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:201:3:error:
> unknown type name 'string'; did you mean 'std::string'?
>   string url_fetcher_response_string_;
>   ^~~~~~
>   std::string

Kinaba, thanks for pointing me out. I was mis-leading by the step error "running
steps via annotated script". Now it finally landed.