components/component_updater/test/component_updater_ping_manager_unittest.cc - Issue 763833003: Remove using namespace in net/quic/quic_stream_sequencer.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/test/component_updater_ping_manager_unittest.cc

Issue 763833003: Remove using namespace in net/quic/quic_stream_sequencer.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/network_stats_unittest.cc ('k') | components/component_updater/test/update_checker_unittest.cc » ('j') | net/quic/congestion_control/send_algorithm_simulator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/test/component_updater_ping_manager_unittest.cc

diff --git a/components/component_updater/test/component_updater_ping_manager_unittest.cc b/components/component_updater/test/component_updater_ping_manager_unittest.cc

index 6504f3f22ec01a23cff6830abe29df1a9ad24417..3f0c43c60e43e91a4f97cf9c5dcb0f0383a6bc51 100644

--- a/components/component_updater/test/component_updater_ping_manager_unittest.cc

+++ b/components/component_updater/test/component_updater_ping_manager_unittest.cc

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <string>

#include "base/memory/scoped_ptr.h"

#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

@@ -71,7 +73,7 @@ TEST_F(ComponentUpdaterPingManagerTest, DISABLED_PingManagerTest) {

base::RunLoop().RunUntilIdle();

EXPECT_EQ(1, interceptor->GetCount()) << interceptor->GetRequestsAsString();

- EXPECT_NE(string::npos,

+ EXPECT_NE(std::string::npos,

interceptor->GetRequests()[0].find(

"<app appid=\"abc\" version=\"1.0\" nextversion=\"2.0\">"

"<event eventtype=\"3\" eventresult=\"1\"/></app>"))

@@ -89,7 +91,7 @@ TEST_F(ComponentUpdaterPingManagerTest, DISABLED_PingManagerTest) {

base::RunLoop().RunUntilIdle();

EXPECT_EQ(1, interceptor->GetCount()) << interceptor->GetRequestsAsString();

- EXPECT_NE(string::npos,

+ EXPECT_NE(std::string::npos,

interceptor->GetRequests()[0].find(

"<app appid=\"abc\" version=\"1.0\" nextversion=\"2.0\">"

"<event eventtype=\"3\" eventresult=\"0\"/></app>"))

@@ -117,7 +119,7 @@ TEST_F(ComponentUpdaterPingManagerTest, DISABLED_PingManagerTest) {

base::RunLoop().RunUntilIdle();

EXPECT_EQ(1, interceptor->GetCount()) << interceptor->GetRequestsAsString();

- EXPECT_NE(string::npos,

+ EXPECT_NE(std::string::npos,

interceptor->GetRequests()[0].find(

"<app appid=\"abc\" version=\"1.0\" nextversion=\"2.0\">"

"<event eventtype=\"3\" eventresult=\"0\" errorcat=\"1\" "

@@ -158,7 +160,7 @@ TEST_F(ComponentUpdaterPingManagerTest, DISABLED_PingManagerTest) {

EXPECT_EQ(1, interceptor->GetCount()) << interceptor->GetRequestsAsString();

EXPECT_NE(

- string::npos,

+ std::string::npos,

interceptor->GetRequests()[0].find(

"<app appid=\"abc\" version=\"1.0\" nextversion=\"2.0\">"

"<event eventtype=\"3\" eventresult=\"1\"/>"