Remove using namespace in net/quic/quic_stream_sequencer.h

google_apis/drive/drive_api_requests_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_reader.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "google_apis/drive/drive_api_parser.h"
 #include "google_apis/drive/drive_api_requests.h"
 #include "google_apis/drive/drive_api_url_generator.h"
 #include "google_apis/drive/dummy_auth_service.h"
 #include "google_apis/drive/request_sender.h"
 #include "google_apis/drive/test_util.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/embedded_test_server/http_request.h"
 #include "net/test/embedded_test_server/http_response.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+using std::string;

[kinaba, 2014/12/04 02:04:01]

The uses of unqualified 'string' are not intentional, they are just mistakes, at
least under google_apis/drive.

Rather than adding the declaration, could you replace all unqualified
occurrences of string with std::string instead? Thanks for catching this!

[haltonhuo, 2014/12/04 02:14:32]

Done locally, and i removed the using std::string as well. Will upload new patch
set in case I need furthure change on other unreviewed parts. 

+
 namespace google_apis {
 
 namespace {
 
 const char kTestETag[] = "test_etag";
 const char kTestUserAgent[] = "test-user-agent";
 
 const char kTestChildrenResponse[] =
     "{\n"
     "\"kind\": \"drive#childReference\",\n"
@@ skipping 1809 matching lines @@
   expected.reset(base::JSONReader::Read(
       "{\"role\":\"writer\", \"type\":\"domain\",\"value\":\"example.com\"}"));
   ASSERT_TRUE(expected);
 
   result.reset(base::JSONReader::Read(http_request_.content));
   EXPECT_TRUE(http_request_.has_content);
   EXPECT_TRUE(base::Value::Equals(expected.get(), result.get()));
 }
 
 }  // namespace google_apis