chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc - Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc

Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc ('k') | chrome/browser/ui/webui/sync_internals_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc b/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc

index f217fca3e52326a8ba2a752cde80d5d368a6fc51..3bd9856d56d711f9eefea6837454373eaf8a8698 100644

--- a/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc

+++ b/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc

@@ -276,11 +276,8 @@ class SyncSetupHandlerTest : public testing::Test {

mock_signin_ = static_cast<SigninManagerBase*>(

SigninManagerFactory::GetForProfile(profile_.get()));

std::string username = GetTestUser();

- if (!username.empty()) {

+ if (!username.empty())

mock_signin_->SetAuthenticatedUsername(username);

- profile_->GetPrefs()->SetString(prefs::kGoogleServicesUsername,

- username);

- }

mock_pss_ = static_cast<ProfileSyncServiceMock*>(

ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(