Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3733)

Unified Diff: chrome/browser/ui/webui/sync_internals_browsertest.js

Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nullptr Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_internals_browsertest.js
diff --git a/chrome/browser/ui/webui/sync_internals_browsertest.js b/chrome/browser/ui/webui/sync_internals_browsertest.js
index 3bd6a6317e8032b6d029199e99820d532157fbaa..b623cbc455cf446a6995ea7009fedbd519801063 100644
--- a/chrome/browser/ui/webui/sync_internals_browsertest.js
+++ b/chrome/browser/ui/webui/sync_internals_browsertest.js
@@ -231,10 +231,24 @@ NETWORK_EVENT_DETAILS_2 = {
TEST_F('SyncInternalsWebUITest', 'Uninitialized', function() {
assertNotEquals(null, chrome.sync.aboutInfo);
- expectTrue(this.hasInDetails(true, 'Username', ''));
expectTrue(this.hasInDetails(false, 'Summary', 'Uninitialized'));
});
+// Test that username is set correctly when the user is signed in or not.
+// On chromeos, browser tests are signed in by default. On other platforms,
+// browser tests are signed out.
+GEN('#if defined(OS_CHROMEOS)');
+TEST_F('SyncInternalsWebUITest', 'SignedIn', function() {
+ assertNotEquals(null, chrome.sync.aboutInfo);
+ expectTrue(this.hasInDetails(true, 'Username', 'stub-user@example.com'));
+});
+GEN('#else');
+TEST_F('SyncInternalsWebUITest', 'SignedOut', function() {
+ assertNotEquals(null, chrome.sync.aboutInfo);
+ expectTrue(this.hasInDetails(true, 'Username', ''));
+});
+GEN('#endif // defined(OS_CHROMEOS)');
+
TEST_F('SyncInternalsWebUITest', 'LoadPastedAboutInfo', function() {
// Expose the text field.
$('import-status').click();
« no previous file with comments | « chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc ('k') | chrome/test/data/webui/ntp4_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698