chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc - Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc ('k') | chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc b/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

index e4c71208ec1bbb52e88a30bffc9c197cea1f7081..c035d06435f34fc2e32d41cd525628c3cabae541 100644

--- a/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

+++ b/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

@@ -12,12 +12,14 @@

#include "chrome/browser/chromeos/profiles/profile_helper.h"

#include "chrome/browser/chromeos/settings/cros_settings.h"

#include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h"

+#include "chrome/browser/signin/signin_manager_factory.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/pref_names.h"

#include "chrome/test/base/ui_test_utils.h"

#include "chromeos/settings/cros_settings_names.h"

+#include "components/signin/core/browser/signin_manager.h"

#include "components/user_manager/user_manager.h"

#include "content/public/browser/web_contents.h"

#include "content/public/test/browser_test_utils.h"

@@ -132,8 +134,8 @@ class SharedOptionsTest : public LoginManagerTest {

// Creates a browser and navigates to the Settings page.

Browser* CreateBrowserForUser(const user_manager::User* user) {

Profile* profile = ProfileHelper::Get()->GetProfileByUserUnsafe(user);

- profile->GetPrefs()->SetString(prefs::kGoogleServicesUsername,

- user->email());

+ SigninManagerFactory::GetForProfile(profile)->

+ SetAuthenticatedUsername(user->email());

ui_test_utils::BrowserAddedObserver observer;

Browser* browser = CreateBrowser(profile);