Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 763043002: Remove RenderBlockLineLayout (Closed)

Created:
6 years ago by rafaelw
Modified:
6 years ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove RenderBlockLineLayout. This patch moves most of the RenderBlockFlow from RenderBlockLineLayout methods into RenderParagraph. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2e0f5392db344cffe291e1630b374e3f99b3b947

Patch Set 1 #

Patch Set 2 : diff #

Patch Set 3 : diff2 #

Total comments: 2

Patch Set 4 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1595 lines, -1672 lines) Patch
M sky/engine/core/core.gni View 2 3 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 2 3 4 chunks +2 lines, -32 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.h View 2 3 6 chunks +2 lines, -43 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 2 3 5 chunks +122 lines, -7 lines 0 comments Download
D sky/engine/core/rendering/RenderBlockLineLayout.cpp View 2 3 1 chunk +0 lines, -1580 lines 0 comments Download
M sky/engine/core/rendering/RenderLineBoxList.cpp View 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderParagraph.h View 2 3 2 chunks +29 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderParagraph.cpp View 2 3 2 chunks +1434 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderText.h View 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/line/LineLayoutState.h View 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rafaelw
6 years ago (2014-11-27 05:04:16 UTC) #2
ojan
lgtm Mostly a rubberstamp though. If you can point out which places you modified code ...
6 years ago (2014-11-27 17:45:32 UTC) #3
rafaelw
see the patchset above named "diff2" for the effective changes to the code from RenderBlockLineLayout ...
6 years ago (2014-11-27 19:22:16 UTC) #4
ojan
lgtm
6 years ago (2014-11-28 00:54:46 UTC) #5
rafaelw
6 years ago (2014-11-28 03:41:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
2e0f5392db344cffe291e1630b374e3f99b3b947.

Powered by Google App Engine
This is Rietveld 408576698