Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: sky/engine/core/rendering/RenderLineBoxList.cpp

Issue 763043002: Remove RenderBlockLineLayout (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: review Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 } 326 }
327 327
328 // If we found a line box, then dirty it. 328 // If we found a line box, then dirty it.
329 if (box) { 329 if (box) {
330 RootInlineBox* adjacentBox; 330 RootInlineBox* adjacentBox;
331 box->markDirty(); 331 box->markDirty();
332 332
333 // dirty the adjacent lines that might be affected 333 // dirty the adjacent lines that might be affected
334 // NOTE: we dirty the previous line because RootInlineBox objects cache 334 // NOTE: we dirty the previous line because RootInlineBox objects cache
335 // the address of the first object on the next line after a BR, which we may be 335 // the address of the first object on the next line after a BR, which we may be
336 // invalidating here. For more info, see how RenderBlock::layoutInlineC hildren 336 // invalidating here. For more info, see how RenderParagraph::layoutChi ldren
337 // calls setLineBreakInfo with the result of findNextLineBreak. findNex tLineBreak, 337 // calls setLineBreakInfo with the result of findNextLineBreak. findNex tLineBreak,
338 // despite the name, actually returns the first RenderObject after the B R. 338 // despite the name, actually returns the first RenderObject after the B R.
339 // <rdar://problem/3849947> "Typing after pasting line does not appear u ntil after window resize." 339 // <rdar://problem/3849947> "Typing after pasting line does not appear u ntil after window resize."
340 adjacentBox = box->prevRootBox(); 340 adjacentBox = box->prevRootBox();
341 if (adjacentBox) 341 if (adjacentBox)
342 adjacentBox->markDirty(); 342 adjacentBox->markDirty();
343 adjacentBox = box->nextRootBox(); 343 adjacentBox = box->nextRootBox();
344 // If |child| or any of its immediately previous siblings with culled li neboxes is the object after a line-break in |box| or the linebox after it 344 // If |child| or any of its immediately previous siblings with culled li neboxes is the object after a line-break in |box| or the linebox after it
345 // then that means |child| actually sits on the linebox after |box| (or is its line-break object) and so we need to dirty it as well. 345 // then that means |child| actually sits on the linebox after |box| (or is its line-break object) and so we need to dirty it as well.
346 if (adjacentBox && (potentialLineBreakObjects.contains(box->lineBreakObj ()) || potentialLineBreakObjects.contains(adjacentBox->lineBreakObj()) || isIsol ated(container->style()->unicodeBidi()))) 346 if (adjacentBox && (potentialLineBreakObjects.contains(box->lineBreakObj ()) || potentialLineBreakObjects.contains(adjacentBox->lineBreakObj()) || isIsol ated(container->style()->unicodeBidi())))
(...skipping 11 matching lines...) Expand all
358 ASSERT(child->prevLineBox() == prev); 358 ASSERT(child->prevLineBox() == prev);
359 prev = child; 359 prev = child;
360 } 360 }
361 ASSERT(prev == m_lastLineBox); 361 ASSERT(prev == m_lastLineBox);
362 #endif 362 #endif
363 } 363 }
364 364
365 #endif 365 #endif
366 366
367 } 367 }
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderBlockLineLayout.cpp ('k') | sky/engine/core/rendering/RenderParagraph.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698