Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 761963006: MSE: Log more details during completing ChunkDemuxerStream reads (Closed)

Created:
6 years ago by wolenetz
Modified:
6 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MSE: Log more details during completing ChunkDemuxerStream reads This change adds more debug logging to help diagnose issues occurring during completing pending reads of ChunkDemuxerStream. It also includes more logs in SourceBufferStream::GetNextBuffer(). These logs are useful for debugging issues like the referenced bug. R=dalecurtis@chromium.org BUG=423858 Committed: https://crrev.com/ecf63c8e50754572ed642ac5a1e7789afef4e83c Cr-Commit-Position: refs/heads/master@{#307104}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix regression introduced by PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M media/filters/chunk_demuxer.cc View 2 chunks +14 lines, -1 line 0 comments Download
M media/filters/source_buffer_stream.cc View 1 1 chunk +21 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
wolenetz
Please take a look. Thanks, Matt
6 years ago (2014-12-05 00:28:33 UTC) #1
DaleCurtis
lgtm
6 years ago (2014-12-05 00:33:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761963006/1
6 years ago (2014-12-05 00:38:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/15246) linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/11758)
6 years ago (2014-12-05 01:46:17 UTC) #6
wolenetz
Dale - PTAL @ PS2. PS1 broke things... https://codereview.chromium.org/761963006/diff/1/media/filters/source_buffer_stream.cc File media/filters/source_buffer_stream.cc (right): https://codereview.chromium.org/761963006/diff/1/media/filters/source_buffer_stream.cc#newcode967 media/filters/source_buffer_stream.cc:967: << ...
6 years ago (2014-12-05 22:13:43 UTC) #7
DaleCurtis
Ah yeah, sorry I didn't notice you reordered that :| lgtm
6 years ago (2014-12-05 22:14:54 UTC) #8
wolenetz
Thanks - All was well until preroll/splicing occurred, which of course didn't get hit when ...
6 years ago (2014-12-05 22:17:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761963006/20001
6 years ago (2014-12-05 22:18:08 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-05 23:22:31 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-05 23:23:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ecf63c8e50754572ed642ac5a1e7789afef4e83c
Cr-Commit-Position: refs/heads/master@{#307104}

Powered by Google App Engine
This is Rietveld 408576698