Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: media/filters/source_buffer_stream.cc

Issue 761963006: MSE: Log more details during completing ChunkDemuxerStream reads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix regression introduced by PS1 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/chunk_demuxer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/source_buffer_stream.cc
diff --git a/media/filters/source_buffer_stream.cc b/media/filters/source_buffer_stream.cc
index 67b7245afb44680c1be7b50f72496afb429ebab6..faba8ec9d1e8d75832cd3ce30296e4c7b766397a 100644
--- a/media/filters/source_buffer_stream.cc
+++ b/media/filters/source_buffer_stream.cc
@@ -958,17 +958,34 @@ void SourceBufferStream::OnSetDuration(base::TimeDelta duration) {
SourceBufferStream::Status SourceBufferStream::GetNextBuffer(
scoped_refptr<StreamParserBuffer>* out_buffer) {
+ DVLOG(2) << __FUNCTION__ << " " << GetStreamTypeName();
if (!pending_buffer_.get()) {
const SourceBufferStream::Status status = GetNextBufferInternal(out_buffer);
- if (status != SourceBufferStream::kSuccess || !SetPendingBuffer(out_buffer))
+ if (status != SourceBufferStream::kSuccess ||
+ !SetPendingBuffer(out_buffer)) {
+ DVLOG(2) << __FUNCTION__ << " " << GetStreamTypeName()
+ << ": no pending buffer, returning status " << status;
return status;
+ }
}
- if (!pending_buffer_->splice_buffers().empty())
- return HandleNextBufferWithSplice(out_buffer);
+ if (!pending_buffer_->splice_buffers().empty()) {
+ const SourceBufferStream::Status status =
+ HandleNextBufferWithSplice(out_buffer);
+ DVLOG(2) << __FUNCTION__ << " " << GetStreamTypeName()
+ << ": handled next buffer with splice, returning status "
+ << status;
+ return status;
+ }
DCHECK(pending_buffer_->preroll_buffer().get());
- return HandleNextBufferWithPreroll(out_buffer);
+
+ const SourceBufferStream::Status status =
+ HandleNextBufferWithPreroll(out_buffer);
+ DVLOG(2) << __FUNCTION__ << " " << GetStreamTypeName()
+ << ": handled next buffer with preroll, returning status "
+ << status;
+ return status;
}
SourceBufferStream::Status SourceBufferStream::HandleNextBufferWithSplice(
« no previous file with comments | « media/filters/chunk_demuxer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698