Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: media/filters/chunk_demuxer.cc

Issue 761963006: MSE: Log more details during completing ChunkDemuxerStream reads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix regression introduced by PS1 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/source_buffer_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer.cc
diff --git a/media/filters/chunk_demuxer.cc b/media/filters/chunk_demuxer.cc
index 31141438c9c75d363c1aaa9e9f3220bf63bb5396..e14d4731e6db1475e621ee1e959166dc407c231c 100644
--- a/media/filters/chunk_demuxer.cc
+++ b/media/filters/chunk_demuxer.cc
@@ -1058,19 +1058,29 @@ void ChunkDemuxerStream::CompletePendingReadIfPossible_Locked() {
switch (stream_->GetNextBuffer(&buffer)) {
case SourceBufferStream::kSuccess:
status = DemuxerStream::kOk;
+ DVLOG(2) << __FUNCTION__ << ": returning kOk, type " << type_
+ << ", dts " << buffer->GetDecodeTimestamp().InSecondsF()
+ << ", pts " << buffer->timestamp().InSecondsF()
+ << ", dur " << buffer->duration().InSecondsF()
+ << ", key " << buffer->is_key_frame();
break;
case SourceBufferStream::kNeedBuffer:
// Return early without calling |read_cb_| since we don't have
// any data to return yet.
+ DVLOG(2) << __FUNCTION__ << ": returning kNeedBuffer, type "
+ << type_;
return;
case SourceBufferStream::kEndOfStream:
status = DemuxerStream::kOk;
buffer = StreamParserBuffer::CreateEOSBuffer();
+ DVLOG(2) << __FUNCTION__ << ": returning kOk with EOS buffer, type "
+ << type_;
break;
case SourceBufferStream::kConfigChange:
- DVLOG(2) << "Config change reported to ChunkDemuxerStream.";
status = kConfigChanged;
buffer = NULL;
+ DVLOG(2) << __FUNCTION__ << ": returning kConfigChange, type "
+ << type_;
break;
}
break;
@@ -1080,10 +1090,13 @@ void ChunkDemuxerStream::CompletePendingReadIfPossible_Locked() {
// because they are associated with the seek.
status = DemuxerStream::kAborted;
buffer = NULL;
+ DVLOG(2) << __FUNCTION__ << ": returning kAborted, type " << type_;
break;
case SHUTDOWN:
status = DemuxerStream::kOk;
buffer = StreamParserBuffer::CreateEOSBuffer();
+ DVLOG(2) << __FUNCTION__ << ": returning kOk with EOS buffer, type "
+ << type_;
break;
}
« no previous file with comments | « no previous file | media/filters/source_buffer_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698