Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: sandbox/linux/services/credentials_unittest.cc

Issue 761903003: Update from https://crrev.com/306655 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/services/credentials.cc ('k') | sandbox/linux/services/proc_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/services/credentials_unittest.cc
diff --git a/sandbox/linux/services/credentials_unittest.cc b/sandbox/linux/services/credentials_unittest.cc
index 28199fb30a5294526a622ee4a7bb58a845b4f1cf..5951d4ab73a1d7dc3609ec3c9cf763d8f091d0b4 100644
--- a/sandbox/linux/services/credentials_unittest.cc
+++ b/sandbox/linux/services/credentials_unittest.cc
@@ -57,56 +57,6 @@ TEST(Credentials, CreateAndDestroy) {
scoped_ptr<Credentials> cred2(new Credentials);
}
-TEST(Credentials, CountOpenFds) {
- base::ScopedFD proc_fd(open("/proc", O_RDONLY | O_DIRECTORY));
- ASSERT_TRUE(proc_fd.is_valid());
- Credentials creds;
- int fd_count = creds.CountOpenFds(proc_fd.get());
- int fd = open("/dev/null", O_RDONLY);
- ASSERT_LE(0, fd);
- EXPECT_EQ(fd_count + 1, creds.CountOpenFds(proc_fd.get()));
- ASSERT_EQ(0, IGNORE_EINTR(close(fd)));
- EXPECT_EQ(fd_count, creds.CountOpenFds(proc_fd.get()));
-}
-
-TEST(Credentials, HasOpenDirectory) {
- Credentials creds;
- // No open directory should exist at startup.
- EXPECT_FALSE(creds.HasOpenDirectory(-1));
- {
- // Have a "/dev" file descriptor around.
- int dev_fd = open("/dev", O_RDONLY | O_DIRECTORY);
- base::ScopedFD dev_fd_closer(dev_fd);
- EXPECT_TRUE(creds.HasOpenDirectory(-1));
- }
- EXPECT_FALSE(creds.HasOpenDirectory(-1));
-}
-
-TEST(Credentials, HasOpenDirectoryWithFD) {
- Credentials creds;
-
- int proc_fd = open("/proc", O_RDONLY | O_DIRECTORY);
- base::ScopedFD proc_fd_closer(proc_fd);
- ASSERT_LE(0, proc_fd);
-
- // Don't pass |proc_fd|, an open directory (proc_fd) should
- // be detected.
- EXPECT_TRUE(creds.HasOpenDirectory(-1));
- // Pass |proc_fd| and no open directory should be detected.
- EXPECT_FALSE(creds.HasOpenDirectory(proc_fd));
-
- {
- // Have a "/dev" file descriptor around.
- int dev_fd = open("/dev", O_RDONLY | O_DIRECTORY);
- base::ScopedFD dev_fd_closer(dev_fd);
- EXPECT_TRUE(creds.HasOpenDirectory(proc_fd));
- }
-
- // The "/dev" file descriptor should now be closed, |proc_fd| is the only
- // directory file descriptor open.
- EXPECT_FALSE(creds.HasOpenDirectory(proc_fd));
-}
-
SANDBOX_TEST(Credentials, DropAllCaps) {
Credentials creds;
CHECK(creds.DropAllCapabilities());
« no previous file with comments | « sandbox/linux/services/credentials.cc ('k') | sandbox/linux/services/proc_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698