Issue 761503004: Fix several leaks in the Sky compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 761503004: Fix several leaks in the Sky compositor (Closed)

Created:
6 years ago by abarth-chromium

Modified:
6 years ago

Reviewers:
ojan

CC:
ojan, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org, rafaelw, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix several leaks in the Sky compositor When tearing down the Sky compostior, we need to destroy the GL context and all the textures in the resource manager. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/aef6f0d7849770c9c1725d378f50677ae3357b12

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -8 lines)			Patch
M	mojo/gpu/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	mojo/gpu/gl_context_owner.h	View	1 chunk	+31 lines, -0 lines	0 comments	Download
A	mojo/gpu/gl_context_owner.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	sky/compositor/layer_host.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	sky/compositor/layer_host.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/compositor/resource_manager.cc	View	3 chunks	+9 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm https://codereview.chromium.org/761503004/diff/20001/sky/compositor/resource_manager.cc File sky/compositor/resource_manager.cc (right): https://codereview.chromium.org/761503004/diff/20001/sky/compositor/resource_manager.cc#newcode29 sky/compositor/resource_manager.cc:29: resource_to_texture_map_.end()); git cl format plz

6 years ago (2014-11-25 19:27:47 UTC) #2

abarth-chromium

6 years ago (2014-11-25 20:11:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
aef6f0d7849770c9c1725d378f50677ae3357b12 (presubmit successful).

Expand Messages | Collapse Messages