Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: sky/compositor/layer_host.h

Issue 761503004: Fix several leaks in the Sky compositor (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix typo Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SKY_COMPOSITOR_LAYER_HOST_H_ 5 #ifndef SKY_COMPOSITOR_LAYER_HOST_H_
6 #define SKY_COMPOSITOR_LAYER_HOST_H_ 6 #define SKY_COMPOSITOR_LAYER_HOST_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
11 #include "mojo/gpu/gl_context_owner.h"
11 #include "mojo/skia/ganesh_context.h" 12 #include "mojo/skia/ganesh_context.h"
12 #include "sky/compositor/layer_host_client.h" 13 #include "sky/compositor/layer_host_client.h"
13 #include "sky/compositor/resource_manager.h" 14 #include "sky/compositor/resource_manager.h"
14 #include "sky/compositor/surface_holder.h" 15 #include "sky/compositor/surface_holder.h"
15 16
16 namespace sky { 17 namespace sky {
17 class ResourceManager; 18 class ResourceManager;
18 class Layer; 19 class Layer;
19 class LayerHostClient; 20 class LayerHostClient;
20 21
21 class LayerHost : public SurfaceHolder::Client { 22 class LayerHost : public SurfaceHolder::Client {
22 public: 23 public:
23 explicit LayerHost(LayerHostClient* client); 24 explicit LayerHost(LayerHostClient* client);
24 ~LayerHost(); 25 ~LayerHost();
25 26
26 LayerHostClient* client() const { return client_; } 27 LayerHostClient* client() const { return client_; }
27 28
28 const base::WeakPtr<mojo::GLContext>& gl_context() const { 29 const base::WeakPtr<mojo::GLContext>& gl_context() const {
29 return gl_context_; 30 return gl_context_owner_.context();
30 } 31 }
31 32
32 mojo::GaneshContext* ganesh_context() const { 33 mojo::GaneshContext* ganesh_context() const {
33 return const_cast<mojo::GaneshContext*>(&ganesh_context_); 34 return const_cast<mojo::GaneshContext*>(&ganesh_context_);
34 } 35 }
35 36
36 ResourceManager* resource_manager() const { 37 ResourceManager* resource_manager() const {
37 return const_cast<ResourceManager*>(&resource_manager_); 38 return const_cast<ResourceManager*>(&resource_manager_);
38 } 39 }
39 40
(...skipping 16 matching lines...) Expand all
56 void BeginFrameSoon(); 57 void BeginFrameSoon();
57 void BeginFrame(); 58 void BeginFrame();
58 59
59 void Upload(Layer* layer); 60 void Upload(Layer* layer);
60 void DidCompleteFrame(); 61 void DidCompleteFrame();
61 62
62 LayerHostClient* client_; 63 LayerHostClient* client_;
63 State state_; 64 State state_;
64 bool frame_requested_; 65 bool frame_requested_;
65 SurfaceHolder surface_holder_; 66 SurfaceHolder surface_holder_;
66 base::WeakPtr<mojo::GLContext> gl_context_; 67 mojo::GLContextOwner gl_context_owner_;
67 mojo::GaneshContext ganesh_context_; 68 mojo::GaneshContext ganesh_context_;
68 ResourceManager resource_manager_; 69 ResourceManager resource_manager_;
69 scoped_refptr<Layer> root_layer_; 70 scoped_refptr<Layer> root_layer_;
70 71
71 base::WeakPtrFactory<LayerHost> weak_factory_; 72 base::WeakPtrFactory<LayerHost> weak_factory_;
72 73
73 DISALLOW_COPY_AND_ASSIGN(LayerHost); 74 DISALLOW_COPY_AND_ASSIGN(LayerHost);
74 }; 75 };
75 76
76 } // namespace sky 77 } // namespace sky
77 78
78 #endif // SKY_COMPOSITOR_LAYER_HOST_H_ 79 #endif // SKY_COMPOSITOR_LAYER_HOST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698