Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 760163004: Looking into all changed files to find actions.xml. (Closed)

Created:
6 years ago by gayane -on leave until 09-2017
Modified:
6 years ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Looking into all changed files to find actions.xml. In case actions.xml is included in the changelist the chrome/browser/resources/PRESUBMIT.py shouldn't run because the presubmit for actions.xml will do more complete job. Fixing the bug to look into all changed files in the CL where previously it was only looking at subdirectories of current presubmit script to find actions.xml BUG=439978 Committed: https://crrev.com/e17026679329c19ce4c2b988ee0c33c9cfeaa7fc Cr-Commit-Position: refs/heads/master@{#308244}

Patch Set 1 : Look at all files in CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M PRESUBMIT_test_mocks.py View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/PRESUBMIT_test.py View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
gayane -on leave until 09-2017
asvitkine@ please review these changes
6 years ago (2014-12-05 18:19:33 UTC) #3
Alexei Svitkine (slow)
lgtm please set a BUG= on this Also, I wouldn't TBR owners here - since ...
6 years ago (2014-12-05 21:22:40 UTC) #5
gayane -on leave until 09-2017
On 2014/12/05 21:22:40, Alexei Svitkine wrote: > lgtm > > please set a BUG= on ...
6 years ago (2014-12-08 16:04:22 UTC) #9
Alexei Svitkine (slow)
LGTM, explanation makes sense. Thanks!
6 years ago (2014-12-08 16:14:20 UTC) #10
gayane -on leave until 09-2017
As this CL is connected to the previous CL that you reviewed would you do ...
6 years ago (2014-12-08 16:28:49 UTC) #11
Paweł Hajdan Jr.
LGTM
6 years ago (2014-12-09 16:41:57 UTC) #12
gayane -on leave until 09-2017
On 2014/12/09 16:41:57, Paweł Hajdan Jr. wrote: > LGTM @brettw do owners review for: chrome/browser/resources/PRESUBMIT.py ...
6 years ago (2014-12-11 16:45:24 UTC) #13
gayane -on leave until 09-2017
arv@ would you do owners review for: chrome/browser/resources/PRESUBMIT.py chrome/browser/resources/PRESUBMIT_test.py
6 years ago (2014-12-12 19:34:23 UTC) #16
brettw
lgtm
6 years ago (2014-12-12 22:25:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760163004/20001
6 years ago (2014-12-13 01:47:38 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-12-13 03:48:20 UTC) #21
commit-bot: I haz the power
6 years ago (2014-12-13 03:50:02 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e17026679329c19ce4c2b988ee0c33c9cfeaa7fc
Cr-Commit-Position: refs/heads/master@{#308244}

Powered by Google App Engine
This is Rietveld 408576698